Optimizing Python Code: String Assignment from List

Question

I have a CSV file and I read the contents. I need to verify that every element of each row is not empty:

fname = row[0]
if fname is None:
    flag = -1
lname = row[1]
if lname is None:
    flag = -1
phone = row[2]
if phone is None:
    flag = -1
email = row[3]
if email is None:
    flag = -1
[...]

Is there a way to optimize this code? Is there a way to do something like this in Python:

fname = row[0] if None else flag = -1 ?
[...]

At the end I will check if flag is -1, I send an error notification (because this is a background task)

You could check if any of those values are None in a single statement at the end. — luk2302
– luk2302, Commented Nov 18, 2022 at 19:59
you can use pandas to check if any row of any column has null value check this stackoverflow.com/questions/71116935/… — Shreyanshu
– Shreyanshu, Commented Nov 18, 2022 at 20:06
@DennisWilliamson That works well if it's only 4 columns. Not so good if the csv file has 400, or it's variable. — nigh_anxiety
– nigh_anxiety, Commented Nov 19, 2022 at 0:05

nigh_anxiety · Accepted Answer · 2022-11-18 20:39:47Z

1

if all([len(e) for e in row]):
    # Row is good
else:
    # Row is bad

We can't just do all(row) because there may be a non-empty but falsey value.

answered Nov 18, 2022 at 20:39

nigh_anxiety

2,4592 gold badges7 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

aaf1097 · Accepted Answer · 2022-11-18 20:14:10Z

0

This could help you

with open('testdata1.csv', 'r') as csv_file:
csv_reader = csv.reader(csv_file)
for row in csv_reader:
    if not row[0]:
         continue  # this will skip to the next for loop iteration
    # do your processing here

Found it at https://www.folkstalk.com/tech/python-csv-row-index-is-empty-with-code-examples/

answered Nov 18, 2022 at 20:14

aaf1097

511 silver badge8 bronze badges

1 Comment

Kaiss B. Over a year ago

But what if row[5] is empty? That's the question, every field should be checked individually, my code actually works, I just wanted to optimize it a bit.

Collectives™ on Stack Overflow

Optimizing Python Code: String Assignment from List

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related