PHP - Why does including a function from another file fail?

Question

I am trying to include a function from one PHP file into another and use the function with a parameter and get a return value. All is good until I run the function, where PHP dies. How can I fix this?

timestamp_reader.php:

<?php
function get_time($timestamp){
    $year = substr($timestamp, 0, 4);
    $month = substr($timestamp, 4, 2);
    if(substr($month, 0, 1) == "0")
        $month = substr($month, 1, 1);
    $day = substr($timestamp, 6, 2);
    if(substr($day, 0, 1) == "0")
        $day = substr($day, 1, 1);
    $hour = substr($timestamp, 8, 2);
    if(substr($hour, 0, 1) == "0")
        $hour = substr($hour, 1, 1);
    $hour = intval($hour);
    if($hour > 12){
        $hour = $hour - 12;
        $pm = true;
    }else $pm = false;
    $minute = substr($timestamp, 10, 2);
    if(substr($day, 0, 1) == "0")
    $day = substr($day, 1, 1);
    if($pm) $minute .= " PM";
    else $minute .= " AM";

    return $month . "/" . $day . "/" . $year . " " . $hour . ":" . $minute;
}
?>

And the file that I want access to this function (note, it is in a different directory):

...some PHP code before this...
include "/project/includes/timestamp_reader.php";
while($row=mysql_fetch_array($result)){
    $msg = $row['message'];
    $timestamp = $row['timestamp'];
    $time = get_time($timestamp);
    echo "<p><center>" . $time . " " . $msg . "</center></p>";
}

I'd like to figure this out and use it for a variety of functions so I don't have to type them in every time if possible. Also, I need something similar for creating project-wide variables.

Anyway, thanks for any and all help!

Looks like using date() and strtotime() would be a better idea here. — Rusty Fausak
– Rusty Fausak, Commented Sep 24, 2011 at 20:55
What's the error message? PS, it'd probably be neater to do the time formatting in SQL in your SELECT statement rather than in PHP. (assuming you're using MySql: dev.mysql.com/doc/refman/5.5/en/date-and-time-functions.html ) — John Carter
– John Carter, Commented Sep 24, 2011 at 20:56
Firefox tells me Error in parsing value for 'filter'. Declaration dropped. in error console. — Sefu
– Sefu, Commented Sep 24, 2011 at 20:58
@Richard , what has firefox's console to do with php errors ? — tereško
– tereško, Commented Sep 24, 2011 at 21:05

tereško · Accepted Answer · 2011-09-24 20:57:53Z

1

How about you avoid reinventing a wheel ? .. especially so misshapen one :

answered Sep 24, 2011 at 20:57

tereško

58.5k26 gold badges101 silver badges152 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MrJ · Accepted Answer · 2011-09-24 22:45:56Z

0

Why not use the date() function within PHP?

For example,

$timestamp = "1316922240";
echo date("m-j-Y", $timestamp);

Will print out 09-24-2011 based on that time stamp for right now - if the timestamp was from yesterday, the date echo-ed will be yesterday.

answered Sep 24, 2011 at 22:45

MrJ

1,9382 gold badges17 silver badges30 bronze badges

Comments

3on · Accepted Answer · 2011-09-24 20:55:02Z

0

try with require(), it fails if the path is wrong, which I bet is the case.

answered Sep 24, 2011 at 20:55

3on

6,3493 gold badges29 silver badges22 bronze badges

1 Comment

Niko Over a year ago

As you are including a file with a function, require_once() would be preferable in this case.

Collectives™ on Stack Overflow

PHP - Why does including a function from another file fail?

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related