Statically initialized array?

Question

I was using a the reviewer "codePro Tools" by google and it flagged the flowing:

new Object[] { max }

with "Statically initialized array"

Explanation:

An array initializer is being used to initialize an array.

Recommendation

The array should be initialized dynamically.

are there a good reason for this? or is just better to ignore.

this flag is on a section of rules called "code style".

Thanks

I use static initialisers frequently. I believe that in certain situations they can make structures clearer. — mcfinnigan
– mcfinnigan, Commented Sep 27, 2011 at 10:00
@michael667 I assume not looking at the doc: code.google.com/javadevtools/codepro/doc/features/audit/… — Matthew Farwell
– Matthew Farwell, Commented Sep 27, 2011 at 10:19
final Object[] var = new Object[] { max }; nope flagged as well. — user952887
– user952887, Commented Sep 27, 2011 at 10:20
Well rule disabled... after listen your opinions. I just want to be sure i wasn't missing anything — user952887
– user952887, Commented Sep 27, 2011 at 10:32

Matthew Farwell · Accepted Answer · 2011-09-27 10:04:57Z

4

As always: it depends. It's a question of style. I personally can't see anything wrong with this at all. In this case, I think it would just obscure the code to initialise it dynamically.

I use statically initialized arrays all of the time. Code style is very subjective and varies from project to project, not just from person to person. It's up to you to decide whether it's a good thing for your project.

edited Sep 27, 2011 at 10:04

answered Sep 27, 2011 at 9:58

Matthew Farwell

61.8k18 gold badges134 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

duffymo · Accepted Answer · 2011-09-27 09:59:06Z

2

Take all automated code inspection tools with a grain of salt. They make recommendations, not issue commands.

If you have a good reason for writing your code that way, and can articulate it well to yourself and others, then stick with your code and ignore CodePro.

answered Sep 27, 2011 at 9:59

duffymo

310k46 gold badges376 silver badges571 bronze badges

Collectives™ on Stack Overflow

Statically initialized array?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related