Bash: repeating loop issue (novice user)

Question

Good afternoon, I'm trying to figure out why my variable loop is only using the last line in my do loop to write data my ISLAND loop is finding city names and assigning a static variable (ISLAND-X-XO)

IFS=$'\n'
OUTPUTDIR='/home/IMPACT_COUNT'
for CSR in `ls -1 configs/ | egrep 'router{1-5]'`
do

ISLAND=$(echo $CSR | grep -q "tampa" && echo ISLAND-TAM-MCR-XO) <- does not write
ISLAND=$(echo $CSR | egrep -q "washington-dc|ashburn" && echo ISLAND-WDC-XO) <- writes
COUNT=$(grep "up             up"  /otherconfigs/$CSR | wc -l)
echo $CSR $COUNT >> $OUTPUTDIR/$ISLAND
done

Each one of the "ISLAND" lookups works individually, just not stacked.

Tried [if then] options Expecting multiple lookups in the loop to write to the DIR

To increase the code quality: add a suitable shebang (#!/bin/bash) to your script, then paste it at shellcheck.net and try to implement the recommendations made there. — Cyrus
– Cyrus, Commented Mar 14, 2023 at 22:48
Do what @Cyrus suggested and do not do what was suggested in the 1 answer you have so far - shellcheck would also tell you some (but not all) of the issues with that. If you edit your question to contain a minimal reproducible example with your code after fixing the issues shellcheck tells you about and concise, testable sample input and expected output then we can help you do what you're trying to do the right way. — Ed Morton
– Ed Morton, Commented Mar 14, 2023 at 23:05

krisz · Accepted Answer · 2023-03-14 22:28:12Z

-1

Here:

ISLAND=$(echo $CSR | grep -q "tampa" && echo ISLAND-TAM-MCR-XO) <- does not write
ISLAND=$(echo $CSR | egrep -q "washington-dc|ashburn" && echo ISLAND-WDC-XO) <- writes

You are overwriting the variable in the second line. Try something like this:

if echo $CSR | grep -q "tampa"; then
    ISLAND=ISLAND-TAM-MCR-XO
elif echo $CSR | egrep -q "washington-dc|ashburn"; then
    ISLAND=ISLAND-WDC-XO
fi

answered Mar 14, 2023 at 22:28

krisz

2,6952 gold badges13 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Cyrus Over a year ago

bash has everything built in to find a string in a variable. I suggest to use this syntax.

Collectives™ on Stack Overflow

Bash: repeating loop issue (novice user)

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related