HttpContext.Current.Session is null in MVC 3 application

Question

I have a bilingual MVC 3 application, I use cookies and session to save "Culture" in Session_start method inside Global.aspx.cs file, but direct after it, the session is null.

This is my code:

    protected void Session_Start(object sender, EventArgs e)
    {
        HttpCookie aCookie = Request.Cookies["MyData"];

        if (aCookie == null)
        {
            Session["MyCulture"] = "de-DE";
            aCookie = new HttpCookie("MyData");
            //aCookie.Value = Convert.ToString(Session["MyCulture"]);
            aCookie["MyLang"] = "de-DE";
            aCookie.Expires = System.DateTime.Now.AddDays(21);
            Response.Cookies.Add(aCookie);
        }
        else
        {
            string s = aCookie["MyLang"];
            HttpContext.Current.Session["MyCulture"] = aCookie["MyLang"];
        }
 }

and second time it goes into the "else clause" because the cookie exists; inside my Filter, when it tries set the culutre, Session["MyCulture"] is null.

   public void OnActionExecuting(ActionExecutingContext filterContext)
    {

        System.Threading.Thread.CurrentThread.CurrentUICulture = new System.Globalization.CultureInfo(HttpContext.Current.Session["MyCulture"].ToString());
        System.Threading.Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.CreateSpecificCulture(HttpContext.Current.Session["MyCulture"].ToString());
    }

Related question with correct answer: Calling the Session before any Controller Action is run in MVC @Darin already posted this solution just adding it for reference. — Sergii Kudriavtsev
– Sergii Kudriavtsev, Commented Oct 9, 2011 at 19:16

Darin Dimitrov · Accepted Answer · 2011-10-09 19:05:26Z

13

Why are you using HttpContext.Current in an ASP.NET MVC application? Never use it. That's evil even in classic ASP.NET webforms applications but in ASP.NET MVC it's a disaster that takes all the fun out of this nice web framework.

Also make sure you test whether the value is present in the session before attempting to use it, as I suspect that in your case it's not HttpContext.Current.Session that is null, but HttpContext.Current.Session["MyCulture"]. So:

public void OnActionExecuting(ActionExecutingContext filterContext)
{
    var myCulture = filterContext.HttpContext.Session["MyCulture"] as string;
    if (!string.IsNullOrEmpty(myCulture))
    {
        Thread.CurrentThread.CurrentUICulture = new CultureInfo(myCulture);
        Thread.CurrentThread.CurrentCulture = CultureInfo.CreateSpecificCulture(myCulture);
    }
}

So maybe the root of your problem is that Session["MyCulture"] is not properly initialized in the Session_Start method.

answered Oct 9, 2011 at 19:05

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user217648 Over a year ago

Thank you very much, Yes the root of the problem is the aCookie is not null but I cann't get the value of it. becuase first time (when i delete all cookies of the browser) and cookie is null, I don't get problem and session is not null.

Megacan Over a year ago

You say it's evil and should never be used. Care to elaborate on the alternatives?

Darin Dimitrov Over a year ago

@Megacan, the alternative is provided in my answer: filterContext.HttpContext.Session instead of HttpContext.Current.Session.

Brad Over a year ago

@DarinDimitrov, are you saying HttpContex.Current is bad only in action filters? your answer more broadly states "Why are you using HttpContext.Current in an ASP.NET MVC application? Never use it."

JTech Over a year ago

@DarinDimitrov can you please explain why you believe HttpContext.Current is bad - providing the alternative is great but you have the power to help others gain a better understanding by explaining the reason for the alternative...

Collectives™ on Stack Overflow

HttpContext.Current.Session is null in MVC 3 application

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related