Swiftui view not getting updated when internal model class property changes

Question

class Model: ObservableObject {
   @Published var players: [Player] = []
}

struct PlayerListView: View {
    @ObservedObject var model: Model

    var body: some View {
        List(model.players, id: \.score) { player in
            HStack {
                Text("Name: \(player.name)")
                Text("Score: \(player.score)")
                Text("Status: \(player.status)")
                Text("Salary: \(player.salary)")
            }
        }
    }
}

struct Player: Codable {
   let name: String
   let score: Int
   let salary: Int
   let status: String
}

so the problem is, if I am performing any operation that increase or decrease the count of players array then view is getting refreshed as expected, but when something internal gets changed like Name, score or any thing by some operations like api calls view is not getting refreshed can anyone please help me out

these solutions are not working in ios14 or above self.objectWillChange.send()

"when something internal gets changed like name" How would that ever happen if name is let? — Sweeper
– Sweeper, Commented Nov 7, 2023 at 10:23
try using: struct Players: Codable { var name: String // var .... } Note the var and the struct not Struct — workingdog support Ukraine
– workingdog support Ukraine, Commented Nov 7, 2023 at 12:02
My guess would be that you are dealing with multiple sources of truth but you haven’t included relevant code to your issue. — lorem ipsum
– lorem ipsum, Commented Nov 7, 2023 at 12:15
@loremipsum, the problem is in big project but the situation is same — Adarsh Ranjan
– Adarsh Ranjan, Commented Nov 8, 2023 at 11:47

malhal · Accepted Answer · 2023-11-08 04:29:01Z

0

Score isn't unique enough to be a ForEach id so change it to:

struct Player: Identifiable {
    let id = UUID() // or var id: String { name } if you enforce unique names.

And

List(model.players) { player in

answered Nov 8, 2023 at 4:29

malhal

31.5k7 gold badges125 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Adarsh Ranjan Over a year ago

no that is not the situation actually internal changes not refreshing the ui

malhal Over a year ago

Internal changes should work, e.g.a change to player will be detected as a change to the array and published should send objectWillChange which causes @ObservedObject to call body. Do you have anything else in your Player struct that might be breaking the check for a difference in Player equality?

Adarsh Ranjan Over a year ago

No when the count is getting increased or decreased it is getting detected and refresh the ui but when the count is same and lets say player salary got changed it is not refreshing the ui

malhal Over a year ago

Are you doing model.players[0].salary = 50 ? You need to be careful with struct values

Adarsh Ranjan Over a year ago

no i m calling change status api which changes to status, but when status got changed ui is not getting refreshed, for refreshing the ui i need to clear array first then i again need to call to get players api which refresh the ui same issue is here as well stackoverflow.com/questions/62461199/…

|

Collectives™ on Stack Overflow

Swiftui view not getting updated when internal model class property changes

1 Answer 1

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related