Why do I get a NullReferenceException when checking for null in the view

Question

I have the following code to display a list of account numbers to the user.

View Model:

Sometimes the list will be null as there will be no accounts to display.

public class AccountsViewModel
{
    public List<string> Accounts { get; set; }
}

View:

@model AccountsViewModel

using (@Html.BeginForm())
{
    <ul>
        @*if there are accounts in the account list*@
        @if (Model.Accounts != null)
        {
            foreach (string account in Model.Accounts)
            {
                <li>Account number* <input type="text" name="account" value="@account"/></li>
            }
        }

        @*display an additional blank text field for the user to add an additional account number*@
        <li>Account number* <input type="text" name="account"/></li>

    </ul>


    ...
}

Everything compiles fine but when I run the page I get a NullReferenceException was unhandled at the line:

@if (Model.Accounts != null)

Why am I getting a null reference exception on a check for a null reference? What am I missing?

I think @ZachJohnson hit it, but also it's standard practice to make any kind of collection default to an empty set. It saves you headaches down the road and from testing null with every use. — Brad Christie
– Brad Christie, Commented Oct 13, 2011 at 14:18
OffTopic: Model.Accounts != null isn't really checking if there arent any account object in the list.. It checks if the list itself is null.. — Rob
– Rob, Commented Oct 13, 2011 at 14:19

Binarian · Accepted Answer · 2017-01-13 13:33:38Z

10

because Model is null and not the property Accounts.

You should check also if Model is not null

Example:

if(Model != null && Model.Accounts != null)
{

}

edited Jan 13, 2017 at 13:33

Binarian

12.5k8 gold badges58 silver badges88 bronze badges

answered Oct 13, 2011 at 14:17

fixagon

5,56624 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sll · Accepted Answer · 2011-10-13 14:17:48Z

3

Obviously Model is null, you've to change condition to

Model != null && Model.Accounts != null

answered Oct 13, 2011 at 14:17

sll

62.7k22 gold badges109 silver badges157 bronze badges

Comments

hunter · Accepted Answer · 2011-10-13 14:17:34Z

2

Your model is probably null

@if (Model != null && Model.Accounts != null)

answered Oct 13, 2011 at 14:17

hunter

63.8k19 gold badges115 silver badges115 bronze badges

Comments

Justin Niessner · Accepted Answer · 2011-10-13 14:18:01Z

1

Without seeing the Action method, I'm assuming your Model is null (which is the only way you would get that error on that line). Just need an extra check:

if(Model != null && Model.Accounts != null)

answered Oct 13, 2011 at 14:18

Justin Niessner

246k40 gold badges416 silver badges546 bronze badges

Collectives™ on Stack Overflow

Why do I get a NullReferenceException when checking for null in the view

4 Answers 4

Example:

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Example:

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related