Error when parsing datetime

Question

I get the following error message in my C# program in the statement:

dr["StartDate"] = Convert.ToDateTime(dr["business_dt"]).ToString("MM/dd/yyyy");

I do not get this error on my US machine.But it throws an error on the user's machine located outside the US. The dateformat being returned from datareader is: 08/31/2010 12:00:00 AM

System.FormatException: String was not recognized as a valid DateTime. at System.DateTimeParse.Parse(String s, DateTimeFormatInfo dtfi, DateTimeStyles styles) at System.Convert.ToDateTime(String value, IFormatProvider provider) at System.String.System.IConvertible.ToDateTime(IFormatProvider provider) at System.Convert.ToDateTime(Object value)

Please advise.

Thanks.

Why does your DataRow contain strings anyway, instead of DateTime values? — Jon Skeet
– Jon Skeet, Commented Oct 14, 2011 at 10:24

Davide Piras · Accepted Answer · 2011-10-14 10:44:36Z

4

Edit:

use DateTime.ParseExact method:

var dateString = dr["business_dt"].ToString();
var format = "MM/dd/yyyy hh:mm:ss tt";
var dateTime = DateTime.ParseExact(dateString, format, CultureInfo.InvariantCulture);
dr["StartDate"] = dateTime;

edited Oct 14, 2011 at 10:44

answered Oct 14, 2011 at 10:16

Davide Piras

44.7k10 gold badges103 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Marco Over a year ago

I tried it and it doesn't work: IMHO you should use var format = "MM/dd/yyyy hh:mm:ss tt"

user74042 Over a year ago

@Davide,@Marco,This did not work for me.Still get the error: "input string was not in correct format".I tried this one too and it gives the same error: DateTime.ParseExact(DateTime.Now.ToString(), "MM/dd/yyyy hh:mm:ss tt", CultureInfo.InvariantCulture);Thanks.

Davide Piras Over a year ago

yeah, use the example in my answer and not this your code from the comment above, it's different...

Marco Over a year ago

No Davide, you edited the wrong part I think: you should do var dateString = dr["business_dt"].ToString(); var format = "MM/dd/yyyy hh:mm:ss tt"; and then the remaining part of the code!!

PVitt Over a year ago

You assume that dr["business_dt"] is of type DateTime. I think it is of type string.

|

PVitt · Accepted Answer · 2011-10-14 10:26:21Z

3

The problem is that in several countries the month and the day part of the date are turned. In US it is "MM/dd/yyyy", in e.g. germany it is "dd/mm/yyyy".

So you have to specify what format your string is in (in your case it looks like the US format so I choosed this culture):

DateTime date = Convert.ToDateTime(dr["business_dt"], new CultureInfo("en-US"));
dr["StartDate"] = date.ToString("MM/dd/yyyy");

edited Oct 14, 2011 at 10:26

answered Oct 14, 2011 at 10:20

PVitt

11.8k5 gold badges54 silver badges85 bronze badges

1 Comment

PVitt Over a year ago

Please post a comment when downvoting.

Sagar Bhat · Accepted Answer · 2011-10-14 11:37:55Z

0

This is happening because the default culture of the machine says that the date format is "dd/MM/yyyy" and in your case, the month is going in as "31" which is incorrect that is why it throws error.

Please set the culture prior to parsing the datetime.

use this code before your code:

CultureInfo CultureInfo1 = (CultureInfo)CultureInfo.CurrentCulture.Clone();
CultureInfo1.DateTimeFormat.ShortDatePattern = "dd/MM/yyyy";
Thread.CurrentThread.CurrentCulture = CultureInfo1;

let me know if this helps.

answered Oct 14, 2011 at 11:37

Sagar Bhat

1217 bronze badges

Comments

Rob L · Accepted Answer · 2016-09-21 05:00:30Z

0

I've just had a related problem in ASP.NET. Issue was occurring on ONE web site on a web server running TWO (almost identical) copies of the code. Had me going for a while, as no logic seemed to fit the symptoms. It turned out to be an issue with the Web.Config. The failing site was missing:

<globalization uiCulture="en" culture="en-AU" /> from the <system.web> section.

Thought I'd just mention this in case it helps anyone.

answered Sep 21, 2016 at 5:00

Rob L

2,4104 gold badges28 silver badges54 bronze badges

Collectives™ on Stack Overflow

Error when parsing datetime

4 Answers 4

7 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

7 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related