How to convert all arguments to string in string formatting [duplicate]

Question

Starting with this from Corey Goldberg:

#!/usr/bin/env python

import json
import pprint
import urllib2


def get_stock_quote(ticker_symbol):   
    url = 'http://finance.google.com/finance/info?q=%s' % ticker_symbol
    lines = urllib2.urlopen(url).read().splitlines()
    return json.loads(''.join([x for x in lines if x not in ('// [', ']')]))


if __name__ == '__main__':
    quote = get_stock_quote('IBM')
    print 'ticker: %s' % quote['t']
    print 'current price: %s' % quote['l_cur']
    print 'last trade: %s' % quote['lt']
    print 'full quote:'
    pprint.pprint(quote)

Using this:

import urllib2, json

def get_stock_quote(ticker_symbol):   
    url = 'http://finance.google.com/finance/info?q=%s' % ticker_symbol
    lines = urllib2.urlopen(url).read().splitlines()
    #print lines
    return json.loads(''.join([x for x in lines if x not in ('// [', ']')]))



if __name__ == '__main__':
    symbols = ('Goog',) 
    symbols2 = ('Goog','MSFT')
    quote = get_stock_quote(symbols)
    print 'ticker: %s' % quote['t'],  'current price: %s' % quote['l_cur'], 'last trade: %s' % quote['ltt']
    print quote['t'],  quote['l'], quote['ltt']

Usings symbols works, symbols2 does not work. The error message is

TypeError: not all arguments converted during string formatting

How do I convert all arguments to string in string formatting. In browser, the code that works is: Goog,MSFT.

EDIT: the output I am looking for is a list with goog, msft info.

naeg · Accepted Answer · 2011-10-14 14:55:04Z

2

Your problem is that %s can't handle a tuple with 2 elements, see that example below:

>>> "=%s" % ('Goog',)
'=Goog'
>>> "=%s" % ('Goog','MSFT')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: not all arguments converted during string formatting

Anyway, use format() instead of %.

answered Oct 14, 2011 at 14:55

naeg

4,0123 gold badges26 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

naeg Over a year ago

See the docs: docs.python.org/library/stdtypes.html#str.format especially note This method of string formatting is the new standard in Python 3.0, and should be preferred to the % formatting ...

naeg Over a year ago

Did you read the page I linked? It's available in Python >= 2.6 ;)

diegueus9 · Accepted Answer · 2011-10-14 22:39:44Z

1

In this case you can make:

import urllib2, json

def get_stock_quote(ticker_symbol):
    if isinstance(ticker_symbol, (list, tuple)):
        ticker_symbol = ','.join(ticker_symbol)
    url = 'http://finance.google.com/finance/info?q=%s' % ticker_symbol
    lines = urllib2.urlopen(url).read().splitlines()
    #print lines
    return json.loads('[%s]' % ''.join([x for x in lines if x not in ('// [', ']')]))

if __name__ == '__main__':
    symbols = ('Goog',) 
    symbols2 = ('Goog','MSFT')
    quotes = get_stock_quote(symbols2)
    for quote in quotes:
        print 'ticker: %s' % quote['t'],  'current price: %s' % quote['l_cur'], 'last trade: %s' % quote['ltt']
        print quote['t'],  quote['l'], quote['ltt']

edited Oct 14, 2011 at 22:39

answered Oct 14, 2011 at 14:56

diegueus9

32.1k16 gold badges65 silver badges75 bronze badges

2 Comments

Merlin Over a year ago

My fault the output is only goog info, the msft info is missing. Looking for list with goog and msft info.

diegueus9 Over a year ago

That is because in the code i try with symbols, but if you change that to symbols2 show what you want

varela · Accepted Answer · 2011-10-14 14:54:24Z

0

You got this error because formatting require only one string, while you put tuple with 2 strings. If you want to get http://finance.google.com/finance/info?q=Goog,MSFT you should do

quote = get_stock_quote(",".join(['Goog','MSFT']))

Or do this in cycle:

for symbol in ('Goog', 'MSFT'):
    quote = get_stock_quote(symbol)

answered Oct 14, 2011 at 14:54

varela

1,3311 gold badge10 silver badges16 bronze badges

Comments

NPE · Accepted Answer · 2011-10-14 14:54:44Z

0

The problem is here:

url = 'http://finance.google.com/finance/info?q=%s' % ticker_symbol

With symbols2, you're supplying a 2-tuple whereas the formatting operator expects a scalar or a 1-tuple.

The following will fix the immediate error:

url = 'http://finance.google.com/finance/info?q=%s' % ",".join(ticker_symbol)

This only fixes half of the problem: the code that parses the results will also need to change. I leave this as an exercise for the reader.

answered Oct 14, 2011 at 14:54

NPE

503k114 gold badges970 silver badges1k bronze badges

1 Comment

Merlin Over a year ago

The second half of your answer: any help

Collectives™ on Stack Overflow

How to convert all arguments to string in string formatting [duplicate]

4 Answers 4

2 Comments

2 Comments

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

2 Comments

Comments

1 Comment

Linked

Related