How to simultaneously perform multiple animations to one element in SwiftUI?

Question

I have a WaveView which is just a sine wave and a rectangle. To make it act like a real wave, I need it to translate unstoppably. So I wrote a Wave view and added an animation on offset with a timer in .onAppear. (I've already tried .animation(.linear(duration: 3).repeatForever(autoreverses: false), value: offset) but that has the same issue) Then, as soon as the Wave view appears, it keeps moving like a wave. Everything works fine.

Then I want to add another animation to the variable progress so that I can animate the progress change as well.

What I expect is that the wave keeps moving and the progress (the height of the blue part that we can see) goes up with an animation. But as soon as the progress changes, the animation on progress gets performed but the wave animation stops, until the timer fires for the next time.

What should I do to keep the wave animation while animating progress?

p.s. Things gets worse with .animation(.linear(duration: 3).repeatForever(autoreverses: false), value: offset) since there's no timer, and I only change offset once, so once this animation gets interrupted, the wave just never start moving again.

struct WaveView: View {
    
    var waveHeight: CGFloat
    
    var body: some View {
        GeometryReader { global in
            Path { path in
                let width = global.size.width
                
                path.move(to: CGPoint(x: width*2.0, y: waveHeight))
                path.addLine(to: CGPoint(x:width*2.0,y: global.size.height))
                path.addLine(to: CGPoint(x:0,y:global.size.height))
                path.addLine(to: CGPoint(x:0,y: waveHeight))
                
                var points = [CGPoint]()
                for angle in stride(from: 0, through: 180.0*4, by: 1) {
                    let radian = angle * .pi / 180
                    let cosValue = cos(radian)
                    let x =  CGFloat(angle) * global.size.width / 360
                    let y = (1+cosValue) * waveHeight / 2
                    points.append(CGPoint(x: x, y: y))
                }
                
                path.addLines(points)
            }
            .fill(.blue.opacity(0.5))
        }
    }
}

struct Wave: View {
    
    init(progress: Binding<Float>, waveHeight height: CGFloat = 200) {
        waveHeight = height
        self._progress = progress
    }
    
    var waveHeight: CGFloat
    
    @Binding var progress: Float
    @State var offset: CGFloat = 0
    
    
    @State var timer: Timer?
    
    var body: some View {
        GeometryReader { global in
            ZStack(alignment: .bottom) {
                    WaveView(waveHeight: waveHeight)
                    .onAppear {
                        timer = .scheduledTimer(withTimeInterval: 3, repeats: true, block: { _ in
                            if offset >= 1 {
                                offset = 0
                            }
                            withAnimation(.linear(duration: 3)) {
                                offset += 1
                            }
                        })
                        timer?.fire()
                    }
                    .onDisappear {
                        timer?.invalidate()
                        timer = nil
                    }
            }
            .frame(width: global.size.width, height: global.size.height)
            
            .position(x: global.size.width * (0.5-offset),y: global.size.height/2)
            .offset(y:CGFloat(1-progress)*global.size.height)
            .animation(.easeInOut(duration: 0.4), value: progress)
            
        }
    }
}

struct TestView: View {
    
    @State var progress: Float = 0.6
    
    var body: some View {
        ZStack{
            Wave(progress: $progress, waveHeight: 35)
                .edgesIgnoringSafeArea(.all)
            VStack {
                Stepper("progress: \(progress.description)",value: $progress, in: 0.0...1.0, step: 0.2)
                    .padding(.horizontal,40)
            }
        }
    }
}

#Preview {
    TestView()
}

normal wave

wave animation that gets interrupted by animation on progress

There's no definition of WaveView. Please, provide a minmal reproducible example: stackoverflow.com/help/minimal-reproducible-example — MatBuompy
– MatBuompy, Commented Jan 25, 2024 at 16:45
Have you tried detaching the wave part from the progress part? If the progress part was a separate view below the wave then the wave can just be left running. A VStack could be used to join them into one view. Also, suggest using padding or frame height to grow the progress, instead of offset. — Benzy Neez
– Benzy Neez, Commented Jan 25, 2024 at 17:36

Benzy Neez · Accepted Answer · 2024-10-10 07:55:34Z

iOS 17 and above

The way to insulate the first animation from the second is to add .geometryGroup().

Other suggested changes:

Use a repeating animation, instead of a Timer.
The closure used in .onAppear only runs once, so there is no need to check whether the variable offset needs to be incremented or decremented. Just set it to 1 instead.
A .frame does not need to be applied to WaveView, because WaveView includes a GeometryReader. A GeometryReader is greedy and uses all the space available.
The variable waveHeight can be declared using let.

Here is the updated example:

struct Wave: View {
    let waveHeight: CGFloat
    @Binding var progress: Float
    @State var offset: CGFloat = 0

    init(progress: Binding<Float>, waveHeight height: CGFloat = 200) {
        waveHeight = height
        self._progress = progress
    }

    var body: some View {
        GeometryReader { global in
            ZStack(alignment: .bottom) {
                WaveView(waveHeight: waveHeight)
                    .onAppear { offset = 1 }
            }
            .position(x: global.size.width * (0.5-offset), y: global.size.height/2)
            .animation(.linear(duration: 3).repeatForever(autoreverses: false), value: offset)
            .geometryGroup() // 👈 IMPORTANT

            .offset(y: CGFloat(1-progress) * global.size.height)
            .animation(.easeInOut(duration: 0.4), value: progress)
        }
    }
}

Animation

Earlier iOS versions

For earlier versions, .drawingGroup() also works. However, this modifier is more likely to have side effects on other aspects of presentation, so you probably want to use with caution. It does seem to fix the problem in this particular case though.

Answer revised again. Suggest using .geometryGroup() for iOS 17 and above.

richardjorne · Accepted Answer · 2024-01-26 17:59:50Z

One solution is to use .drawingGroup(), thanks to Benzy Neez.

One thing to mention is that .drawingGroup() also works without using VStack. It seems that it can be used to insulate any two animations to make them act together.

Here's a revised version:

struct Wave: View {
    
    init(progress: Binding<Float>, waveHeight height: CGFloat = 200) {
        waveHeight = height
        self._progress = progress
    }
    
    var waveHeight: CGFloat
    
    @Binding var progress: Float
    @State var offset: CGFloat = 0
    
    var body: some View {
        GeometryReader { global in
            ZStack(alignment: .bottom) {
                WaveView(waveHeight: waveHeight)
                    .onAppear {
                        if offset >= 1 {
                            offset = 0
                        }
                        offset += 1
                    }
            }
            .frame(width: global.size.width, height: global.size.height)
            // Animation 1
            .position(x: global.size.width * (0.5-offset),y: global.size.height/2)
            .animation(.linear(duration: 3).repeatForever(autoreverses: false), value: offset)
            .drawingGroup() // <- THE KEY TO INSULATE TWO ANIMATIONS
            // Animation 2
            .offset(y:CGFloat(1-progress)*global.size.height)
            .animation(.easeInOut(duration: 0.4), value: progress)
            
        }
    }
}

In the code above, .drawingGroup() after Animation1 insulates Animation1 and the animations below. The result is that Animation2 will not interrupt Animation1 anymore.

I couldn't find a lot of documents discussing the effect of insulation, but I guess it worked because .drawingGroup() flattened the view into one layer so that the frames as the result of the animation remained but animation data get removed so that SwiftUI thinks there's no animation right after .drawingGroup().

Collectives™ on Stack Overflow

How to simultaneously perform multiple animations to one element in SwiftUI?

2 Answers 2

iOS 17 and above

Earlier iOS versions

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

iOS 17 and above

Earlier iOS versions

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related