Polly v8 - Retrying specific status codes using the PredicateBuilder

Question

I am using Polly v8 and .NET framework 4.7.2 to retry on specific status responses only. However, when trying to restrict the retry to only these statuses the code will no longer invoke the retry behaviors.

It's worth noting that adding a Handle on HttpRequestException would work but begins to retry on additional status codes where the preference is just to fail fast and log

Please see the below example:

public ResiliencePipilineBuilder<HttpResponseMessage> BuildStrategy()
{
    var statusCodes = new List<HttpStatusCode>
    {
        HttpStatusCode.InternalServerError
    };

    PredicateBuilder<HttpResponseMessage> predicateBuilder = new PredicateBuilder<HttpResponseMessage>()
        // .Handle<HttpRequestException>()  NOTE: this would work see explanation
        .HandleResult(response => statusCodes.Contains(response.StatusCode));

    ...

    return new ResiliencePipilineBuilder<HttpResponseMessage>()
        .AddRetry(new RetryStrategyOptions<HttpResponseMessage>()
        {
            ShouldHandle = predicateBuilder,
            ...
        });
}

public async Task<Data> SendIt()
{
    var strategy = BuildStrategy();

    var result = strategy.ExecuteAsync(async token => 
    {
        var response = await client.SendAsync()

        response.EnsureSuccessStatusCode();

        ...
    })
}

Can HandleResult be used by itself to only catch the requests I want in the new v8 style? Would I have to revert to the v7 approach instead?

The Polly docs do show both approaches (Handle and HandleResult) but as a pair rather than individually

Peter Csala · Accepted Answer · 2024-03-14 19:27:22Z

0

The root cause of your problem is not inside the strategy definition rather than inside the decorated method:

response.EnsureSuccessStatusCode();

This code will throw an HttpRequestException if the IsSuccessStatusCode returns false. So, whenever the status code is not in the following range: 200-299.

If you remove this check then your strategy will work in the excepted way.

answered Mar 14, 2024 at 19:27

Peter Csala

23.7k16 gold badges51 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Keiron Over a year ago

Thank you @Peter-Csala, this did the trick. One thing to note I was using the exception from the outcome which no longer exists without this line (fine for my purposes) just in case someone is doing similar

Collectives™ on Stack Overflow

Polly v8 - Retrying specific status codes using the PredicateBuilder

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related