Javascript object manipulation with Jquery $.each()

Question

What am I doing wrong here ???

var menu = {
    menuset : {
        first  : false,
        second : false,
        third  : false
    },
    setMenus   : function (selected) {

        var menuCollection = this.menuset;

        $.each(menuCollection, function (key, element) {
            if (selected===key) {
                key=true;
            } else {
                key=false;
            }
        });
    }
}

When I execute "menu.setMenus(first)" I want it to set the object like this :

    menuset : {
        first  : true,
        second : false,
        third  : false
    }

should I be using something other than $.each() ??

I don't understand why you have to use each in this case. Your setMenus function could be like this: this.menuset[ selected ] = true; (assuming you did all the modifications proposed by Jayendra) — Frias
– Frias, Commented Oct 23, 2011 at 18:51
Luiz think of this as a menu where only one navigation item is "active" hence the loop. — aziz punjani
– aziz punjani, Commented Oct 23, 2011 at 18:57

Jayendra · Accepted Answer · 2011-10-23 18:45:58Z

2

try -

var menu = {
    menuset : {
        'first'  : false,
        'second' : false,
        'third'  : false
    },
    setMenus   : function (selected) {

        var menuCollection = this.menuset;

        $.each(menuCollection, function (key, element) {
            if (selected === key) {
                menuCollection[key] = true;
            } else {
                menuCollection[key] = false;
            }
        });
    }
}

menu.setMenus('first');

Demo - http://jsfiddle.net/nu9v2/

answered Oct 23, 2011 at 18:45

Jayendra

52.8k4 gold badges83 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ryan · Accepted Answer · 2011-10-23 18:43:35Z

1

A couple of things:

first is a property of this.menuset, but you are passing it just as first.
The first arg to the callback fn for $.each is an integer index, but you are passing in a boolean.

answered Oct 23, 2011 at 18:43

Ryan

1,5579 silver badges11 bronze badges

Comments

Raynos · Accepted Answer · 2011-10-23 18:53:59Z

1

You don't need jQuery

var menu = {
    menuset : {
        'first'  : false,
        'second' : false,
        'third'  : false
    },
    setMenus   : function (selected) {
        // set other values to false
        var keys = Object.keys(this.menuset);
        for (var i = 0, len = keys.length; i < len; i++) {
            this.menuset[keys[i]] = false;
        }
        // set correct value to true
        this.menuset[selected] = true;
    }
}

Example

answered Oct 23, 2011 at 18:53

Raynos

170k57 gold badges359 silver badges399 bronze badges

1 Comment

aziz punjani Over a year ago

But if you set another menuset to true both will be true, i think the op's intent is only for ONE menuset to be true, hence the loop.

georg · Accepted Answer · 2011-10-23 19:10:59Z

0

should I be using something other than $.each() ??

I think map would be better here:

setMenus: function (selected) {
   this.menuset = $.map(this.menuset, function(val, key) { return key == selected })
}

answered Oct 23, 2011 at 19:10

georg

216k57 gold badges324 silver badges401 bronze badges

Collectives™ on Stack Overflow

Javascript object manipulation with Jquery $.each()

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related