Page specific javascript function

Question

I have all my javascript code for i project in a single minified library. There are some functions that run only for specific page urls, but when a link that does not have its href attribute and instead has an element id its href attribute is clicked, and the page is refreshed, the function does not run. Any idea what the problem is? For example; it work when the url is http://localhost/pheedbak/users/home but when the url changes to http://localhost/pheedbak/users/home#directed-pheeds, the function doesn't run

The code is something like this

url = "http://localhost/pheedbak/users/home";

    if(window.location.href == url)
    { 
      pheeds.LoadLatestPheeds();
    }

They mean the script relies on link elements with normal URLs and fails for anchor links. — katspaugh
– katspaugh, Commented Oct 29, 2011 at 14:32

Hogan · Accepted Answer · 2011-10-29 14:36:50Z

3

This should work -- only look at the stuff before #

 if(window.location.href.split("#")[0] == url)

or

 if(window.location.href.split("#",1)[0] == url)

nb. not tested -- might contain typos/bugs.

answered Oct 29, 2011 at 14:36

Hogan

70.7k10 gold badges83 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

samliew · Accepted Answer · 2011-10-29 14:36:23Z

2

You can try this, this will match even if there are other querystrings or hash ids:

if(window.location.href.indexOf(url) > -1)

answered Oct 29, 2011 at 14:36

samliew

79.5k112 gold badges174 silver badges319 bronze badges

1 Comment

Naatan Over a year ago

Although this will probably work without problems for the example given, it's not best practice to use this type of method for matching the url. For example, this would also match a query with "/path/to/whatever?url=locahost/pheedbak/users/home", and if you are using relative paths the matching is off all together. Better to be as precise as possible. Of course as in his example this is very unlikely to actually happen.. but that's what best practice is all about. Preventing Murphy's Law.

Vao Tsun · Accepted Answer · 2017-02-01 16:32:24Z

2

You'll need to strip out the important part. Eg

var url = 'pheedbak/users/home';

if(window.location.href.replace(/.*?\/\/.*?\/(.*?)(?:\#|\?).*/,'$1') == url)
{ 
  pheeds.LoadLatestPheeds();
}

This will also work with url's that contain GET variables (eg. /users/home?id=2) and works regardless of domain or protocol.

Domain & Protocol dependent version:

var url = 'http://localhost/pheedbak/users/home';

if(window.location.href.replace(/(.*?)(?:\#|\?).*/,'$1') == url)
{ 
  pheeds.LoadLatestPheeds();
}

edited Feb 1, 2017 at 16:32

Vao Tsun

52.5k13 gold badges114 silver badges149 bronze badges

answered Oct 29, 2011 at 14:40

Naatan

3,4694 gold badges36 silver badges52 bronze badges

Collectives™ on Stack Overflow

Page specific javascript function

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related