c# Accessing WinForm control properties from another class

Question

How does one access WinForm controls such as ProgressBar properties from another class?

Please see my code below. I know this might not be the best option to expose WinForm class and its members as public but I am trying to clear the concept at this point.

namespace WindowsFormsApplication1
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        public void button1_Click(object sender, EventArgs e)
        {
            Class1 c = new Class1();
            c.loop();
        }

        public void PBSetup()
        {
            progressBar1.Minimum = 0;
            progressBar1.Maximum = 100;
        }

        public void PBUpdate(int recno)

        {
            progressBar1.Value = Class1.recno;
        }
    }
}

namespace WindowsFormsApplication1
{
    class Class1
    {

        public static int recno;

        public void loop()
        {
            //How do I access Form1.PBSetup()??

            for (recno = 0; recno <= 100; recno++)
            {
                //How do I access Form1.PBUpdate(recno)??
            }
        }
    }
}

Must be a duplicate of at least a dozen questions...

MPelletier
– MPelletier

2011-11-01 19:58:26 +00:00
Commented Nov 1, 2011 at 19:58 — MPelletier
– MPelletier, Commented Nov 1, 2011 at 19:58
Do NOT use numbers in class and variable names!

markus
– markus

2011-11-17 23:41:31 +00:00
Commented Nov 17, 2011 at 23:41 — markus
– markus, Commented Nov 17, 2011 at 23:41

Anthony Pegram · Accepted Answer · 2011-11-01 19:57:43Z

3

You do not want your business logic (your class) interacting with your UI (your form). The business logic should be agnostic of the presentation layer.

If you want the form to respond to things that happen inside the class, you could consider exposing an Event inside the class that the form could subscribe to, much like it would subscribe to a button's click event. The class instance could fire off the event completely unaware of who might be listening, and any subscribers would be notified.

answered Nov 1, 2011 at 19:57

Anthony Pegram

128k28 gold badges229 silver badges252 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JonH · Accepted Answer · 2011-11-01 19:56:47Z

1

This looks like a big time code smell :). You would need an instance of Form1 inside of Class1 in order to PBUpdate. Something tells me what you are doing is just not right.

Explain what you are trying to do and we can help. Otherwise there is no way to access PBUpdate unless you either made it a static function where you could call it like Form1.PBUpdate() or you had an instance of Form1 within your class Class1

answered Nov 1, 2011 at 19:56

JonH

33.2k13 gold badges93 silver badges149 bronze badges

Comments

aleroot · Accepted Answer · 2011-11-01 20:11:51Z

1

You can change the access modifiers of the progress bar from private to Internal or public , you can do this operation from properties pane .

Properties pane

Keep in mind that you have to pass to the second class the instance of the form and then you can change the value of the progress bar directly from the second class.

However is a tricky solution, the best should be keep the presentation layer implementation separated and work with an event.

edited Nov 1, 2011 at 20:11

answered Nov 1, 2011 at 19:57

aleroot

73k32 gold badges182 silver badges220 bronze badges

1 Comment

Shazam Over a year ago

I tried to change it to public but still no go, the progressbar1 properties do not show.

Dan · Accepted Answer · 2011-11-01 20:08:54Z

0

I do not recommend to use this method, for simple reason as mentioned here by one of the comments. But if you really want to access that form control, here is how:

1) Select that control and set its access modifier to internal. 2) Assume your form id is "Form1" and control id is "control1"

Inside your method:

Form1 form = (Form1)Application.OpenForms["Form1"];
// form.control1  should now be available.

answered Nov 1, 2011 at 20:08

Dan

3141 silver badge4 bronze badges

Collectives™ on Stack Overflow

c# Accessing WinForm control properties from another class

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related