PhP using explode and replacing strings in a large file

Question

I'm very very new to PHP so any help will do :-)

I want to change -- to : in a large file. What have I done wrong?

$handle = fopen('april.log.txt', 'r');

while  (!feof($handle)){
 $line = fgets($handle, 1024);
 $to_replace =array('--',':');
 $clean = str_replace($to_replace,':',$line);
 echo $line;
}

Why do you need to replace already-existing : characters with :? — BoltClock
– BoltClock, Commented Nov 5, 2011 at 17:26

codaddict · Accepted Answer · 2011-11-05 17:28:37Z

5

You are printing the old string:

echo $line;

You need to print the modified string:

echo $clean;

And you can change your $to_replace to:

$to_replace = '--';

answered Nov 5, 2011 at 17:28

codaddict

457k83 gold badges501 silver badges537 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Benjamin Crouzier · Accepted Answer · 2011-11-05 17:33:13Z

2

Try this:

<?php
$handle = fopen('yourfile.txt', 'r');

while  (!feof($handle)){
 $line = fgets($handle, 1024);
 $line = str_replace('--',':',$line);
 echo $line;
}

2 things:

You don't need to have your search-replace in an array.
You assigned the result of str_replace in $clean instrad of $line

answered Nov 5, 2011 at 17:33

Benjamin Crouzier

42.2k48 gold badges179 silver badges240 bronze badges

Collectives™ on Stack Overflow

PhP using explode and replacing strings in a large file

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related