Adding textViews in a for loop

Question

      scrollview = (ScrollView)findViewById(R.id.detailedScrollView);


  for (Quotation quotation : object.quotes){

          TextView quote = new TextView(this);
          quote.setText(quotation.getQuote());
          quote.setLayoutParams(new LayoutParams(LayoutParams.FILL_PARENT, LayoutParams.WRAP_CONTENT));
          scrollview.addView(quote);


      }

Let's say there are three quotes, then I want to have three textViews. However, the code above crashes my app. Any obvious mistakes? Here's the error I'm getting:

11-06 17:35:53.214: E/AndroidRuntime(1430): java.lang.IllegalStateException: ScrollView can host only one direct child

11-06 17:35:53.214: E/AndroidRuntime(1430): java.lang.IllegalStateException: ScrollView can host only one direct child Ah scrollview can only have one child? I guess I need to put everything in a linearLayout then into the scrollview? — Adam
– Adam, Commented Nov 6, 2011 at 22:44

Thierry · Accepted Answer · 2011-11-06 22:45:15Z

6

You can't add views directly inside a scrollview. A scrollview can only contain a single layout object. What you have to do is to add a linearlayout in your scrollview, then add the textview to the linearlayout

answered Nov 6, 2011 at 22:45

Thierry

1501 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Psycho · Accepted Answer · 2011-11-06 22:50:51Z

3

Layout container for a view hierarchy that can be scrolled by the user, allowing it to be larger than the physical display. A ScrollView is a FrameLayout, meaning you should place one child in it containing the entire contents to scroll; this child may itself be a layout manager with a complex hierarchy of objects. A child that is often used is a LinearLayout in a vertical orientation, presenting a vertical array of top-level items that the user can scroll through.

The TextView class also takes care of its own scrolling, so does not require a ScrollView, but using the two together is possible to achieve the effect of a text view within a larger container. Please more detail

With best regards, Psycho

answered Nov 6, 2011 at 22:50

Psycho

3352 silver badges7 bronze badges

Comments

userAbhi · Accepted Answer · 2016-03-30 07:31:54Z

You need to add a "LinearLayout" (or "RelativeLayout") inside ScrollView. Say you have the layout xml as follows:

<ScrollView
    android:layout_width="match_parent"
    android:layout_height="match_parent">
  <LinearLayout
    android:id="@+id/linearlayout1"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:orientation="vertical"        
    >       
  </LinearLayout>
</ScrollView>

And now you want to add the 'TextView' programmatically, which is as follows:

LinearLayout linearLayout =(LinearLayout) this.findViewById(R.id.linearlayout1);
for (Quotation quotation : object.quotes){
     TextView quote = new TextView(this);
     quote.setLayoutParams(new LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT));
     quote.setPadding(4, 0, 4, 0);    //left,top,right,bottom
     quote.setText(quotation.getQuote());          
     linearLayout.addView(quote);
}

Collectives™ on Stack Overflow

Adding textViews in a for loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related