What do I have to do to display the largest and the smallest number using a loop?

Question

I don't have any idea how to display the largest and smallest number after the user enter -1.

Note: I also have to display the sum of all of this number and the average of this sum.

Here's my code so far:

public static void main(String[] args) {
    // store
    int cnt = 0;
    int acumulator = 0;
    int larger = 0;
    int smaller = 0;
    int number;
    // inputs
    System.out.println("enter the number all the number");
    Scanner kb = new Scanner(System.in);
    number = kb.nextInt();
    // loop
    while (number != -1) {
        acumulator += number;
        number = kb.nextInt();
        cnt++;//
    }
    double average = (acumulator / cnt);
    System.out.println(" The total of your number is=" + acumulator);
    System.out.println(" The average of your number is=" + average);
}

Might I ask what the difference between cnt and count is and why only one is used? :-) — corsiKa
– corsiKa, Commented Nov 6, 2011 at 23:04
cnt is to know how many number have been entered, count is an error. — user1022564
– user1022564, Commented Nov 6, 2011 at 23:10

Wesley · Accepted Answer · 2011-11-06 22:44:40Z

1

Seems like schoolwork, but what you could do is making a var and checking in your while if the input number is higher or lower then the saved var.

if(input > max)
  max = input;

And

if(input < min)
  min = input;

answered Nov 6, 2011 at 22:44

Wesley

2,20018 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

corsiKa Over a year ago

It looks like he already has them, but they're named larger and smaller; they're also unused.

Wesley Over a year ago

Yeah i see, but its more about the idea :)

user1022564 Over a year ago

Thank you so much. the homework is done,but can you explain the logy of this situation or refer me to a wed-side where I can learn this better. My book has a example but it doesn't explain this well and it is too short.

Bohemian · Accepted Answer · 2011-11-07 04:19:23Z

1

I would make the following changes:

use a for loop instead of a while loop (you need intialization, condition and iteration)
use the JDK's API more - Math.min() and Math.max()
spell "accumulator" correctly
remove all variables you are not using (cnt)

Try this:

public static void main(String[] args) {
    int accumulator = 0;
    int largest = Integer.MIN_VALUE;
    int smallest = Integer.MAX_VALUE;
    int count = 0;
    // inputs
    System.out.println("enter a number (-1 to end)");
    Scanner kb = new Scanner(System.in);
    for(int number = kb.nextInt(); number != -1; number = kb.nextInt()) {
        count++;
        accumulator += number;
        largest = number > largest ? number : largest;
        smallest = number < smallest ? number : smallest;
    }
    double average = (accumulator / count);
    System.out.println(" The total of your numbers is=" + accumulator);
    System.out.println(" The average of your numbers is=" + average);
    System.out.println(" The largest of your numbers is=" + largest);
    System.out.println(" The smallest of your numbers is=" + smallest);
}

FYI: Math.min/max could be used instead of the ternary statements, but the above is the simplest java that will achieve the result.

edited Nov 7, 2011 at 4:19

answered Nov 6, 2011 at 23:18

Bohemian♦

427k103 gold badges603 silver badges750 bronze badges

4 Comments

user1022564 Over a year ago

the main problem here is that my teacher has never taught how to use Math.min() and Math.max(), and she may say that it isn't what she wants.

Wesley Over a year ago

Yeah its a good piece of code, but i guess for a beginner it might be confusing.

Bohemian Over a year ago

OK - I've removed the Math.min etc and replaced with ternaries

Harry Wood Over a year ago

But ternaries are also confusing. "if" statements would be the way to go for clear (but not so elegantly compact) beginner code.

user1021229 · Accepted Answer · 2011-11-06 22:46:05Z

0

Basically you need to check each all numbers with each other.Lets say we have numbers 1,2 and 3

here is the code:

public static void main(String[] args){
    int one=1;
    int two=2;
    int three=3;
    if(three>one){
     if(three>two){
       System.out.println("three is biggest");
     }
   }
   if(two>one){
    if(two>three){

   }
}

etc etc.

I think you got idea

answered Nov 6, 2011 at 22:46

user1021229

1791 gold badge1 silver badge5 bronze badges

Comments

Jeff Grigg · Accepted Answer · 2011-11-06 22:44:16Z

-1

You need to use an "if" statement.

answered Nov 6, 2011 at 22:44

Jeff Grigg

1,0148 silver badges7 bronze badges

Collectives™ on Stack Overflow

What do I have to do to display the largest and the smallest number using a loop?

4 Answers 4

3 Comments

4 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related