If I've got a method in a different controller to the one I'm writing in, and I want to call that method, is it possible, or should I consider moving that method to a helper?
2
-
1Could you add facts to the problem you want to solve by calling the method of another controller? Currently it is pretty vague, and the solution will depend on the problem.mliebelt– mliebelt2011-11-22 11:01:05 +00:00Commented Nov 22, 2011 at 11:01
-
Indeed, please elaborate what you are trying to solve. what is the shared method doing?nathanvda– nathanvda2011-11-22 11:21:39 +00:00Commented Nov 22, 2011 at 11:21
Add a comment
|
4 Answers
You could technically create an instance of the other controller and call methods on that, but it is tedious, error prone and highly not recommended.
If that function is common to both controllers, you should probably have it in ApplicationController or another superclass controller of your creation.
class ApplicationController < ActionController::Base
def common_to_all_controllers
# some code
end
end
class SuperController < ApplicationController
def common_to_some_controllers
# some other code
end
end
class MyController < SuperController
# has access to common_to_all_controllers and common_to_some_controllers
end
class MyOtherController < ApplicationController
# has access to common_to_all_controllers only
end
Yet another way to do it as jimworm suggested, is to use a module for the common functionality.
# lib/common_stuff.rb
module CommonStuff
def common_thing
# code
end
end
# app/controllers/my_controller.rb
require 'common_stuff'
class MyController < ApplicationController
include CommonStuff
# has access to common_thing
end
3 Comments
edgerunner
include GoodSuggestion Thanks @jimworm
nathanvda
Creating an instance of the other controller???? Arrrrrrrgggh (indeed). Another option, since the question is so vague: move code to models.
edgerunner
Since there aren't any details on the question(yet) I'm assuming that @cjm2671 is asking for controller specific functionality. Of course, if it is business logic, it must be in the models :)
Try and progressively move you methods to your models, if they don't apply to a model then a helper and if it still needs to be accessed elsewhere put in the ApplicationController
5 Comments
nathanvda
I would never move code from a controller to a helper, rather a module living in
/lib. Only view-code should live in a helper.
Joseph Le Brech
putting something in a helper is only short lived. you'll get to the point where you don't have to put in a lib/ throwing everything into a module isn't too good either.
nathanvda
I prefer using modules over helpers, because they are true OO, i can include/extend them at will. I can group stuff together that has actual meaning. Helpers are just buckets. I recommend to only use those for view-related methods. Not sure what you mean with the
you'll get to the point .....Joseph Le Brech
true OO is putting method in the model. you access them from a controller or view, but obviously you can have them in a module if that function is common and access what you can through a model when ever you can.
nathanvda
There is also functionality that does not belong in a model, but in its own class or module. E.g. an implementation of decryption algorithm, sending sms, ... those belong in
lib (or make a gem).If you requirement has to Do with some DB operations, then you can write a common function (class method) inside that Model. Functions defined inside model are accessible across to all the controllers. But this solution does to apply to all cases.
Comments
I don't know any details of your problem, but maybe paths could be solution in your case (especially if its RESTful action).
http://guides.rubyonrails.org/routing.html#path-and-url-helpers
