Segmentation fault in std::string::assign(std::string const&)

Question

i have the indicated problem with the following code and i have no idea what it might be causing it. I searched before posting the problem, and i learned that it might be something going out of the scope like a reference to a freed memory location but i could not find it on my own. Thank you for helping me.

#include<iostream>
#include<string>
using namespace std;

class USR{
private:
    string name;
public:
    void setName(string name){  
        this->name = name;
    }
    string getName(){
        return name;
    }

};

class A{
private:
    USR* * a;
public:
    A(int size){
        a = new USR*[size];
    }   
    USR* getUser(){
        return a[0];
    }
};

int main(){
    A test = A(5);
    USR* u = test.getUser(); 
    (*u).setName("test");
    USR* u2 = test.getUser(); 
    cout << (*u2).getName() << endl;
    cout << (*u).getName() << endl;
}

Thank you every one, i accepted Björn's answer because he was the first one to reply. — Youssef Khloufi
– Youssef Khloufi, Commented Nov 27, 2011 at 20:13

Mysticial · Accepted Answer · 2011-11-27 20:03:18Z

4

The problem is that you allocated the array of pointers, but you never allocated anything for the pointers themselves.

This gives you the array of pointers:

a = new USR*[size];

But you never allocated anything for each of the pointers.

Therefore, it's crashing here:

(*u).setName("test");

because *u is not initialized.

There are two ways to fix this:

Allocate (and initialize) something for each USR pointer.
Don't use the double pointers. Just use a simple array of USR objects.

I'd prefer the latter since what you have is probably more complicated than it needs to be.

Something like this will probably do what you want:

class A{
private:
    USR *a;
public:
    A(int size){
        a = new USR[size];
    }   
    USR* getUser(){
        return &a[0];
    }
};

Don't forget that you'll want a destructor as well.

edited Nov 27, 2011 at 20:03

answered Nov 27, 2011 at 19:57

Mysticial

473k46 gold badges343 silver badges337 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Björn Pollex · Accepted Answer · 2011-11-27 19:56:23Z

3

Your method getUser returns an uninitialized pointer (the constructor of A creates an array of uninitialized pointers). The error you see is the result of dereferencing the uninitialized pointer that method returned.

answered Nov 27, 2011 at 19:56

Björn Pollex

77.1k30 gold badges206 silver badges290 bronze badges

Comments

halfdan · Accepted Answer · 2011-11-27 19:57:34Z

1

You are only creating a new USR* array instead of an array of USR objects. Accessing the pointer in

USR* u = test.getUser();

will give you an unitialized pointer. Calling

(*u).setName("test");

will therefore segfault.

answered Nov 27, 2011 at 19:57

halfdan

34.3k8 gold badges83 silver badges88 bronze badges

Comments

Igor · Accepted Answer · 2011-11-27 20:10:43Z

1

You initialized an array of USR*s, but you haven't initialized the single USR* objects.

edited Nov 27, 2011 at 20:10

answered Nov 27, 2011 at 20:00

Igor

27.4k28 gold badges93 silver badges114 bronze badges

Comments

Pushpendra · Accepted Answer · 2016-02-03 10:46:03Z

0

As you have declared a 2D array of USR, so i think you have requirement of Array of Array of user names, although it looks weird to me why can't you simply use USR *userArray;

Anyway if you want the array of array of user names to work then you need to modify your class A as below:

class A{
private:
    USR* * a;
public:
    A(int size){
        a = new USR*[size];
        int iter = 0;
        for(; iter < size; iter++)
        {
           a[iter] = new USR[size_of_user_names_for_each_user_array];
        }
    }   
    USR* getUser(){
        return a[0];
    }
};

edited Feb 3, 2016 at 10:46

answered Jul 9, 2015 at 8:08

Pushpendra

4591 gold badge4 silver badges19 bronze badges

Collectives™ on Stack Overflow

Segmentation fault in std::string::assign(std::string const&)

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related