OOP php method - pass variables in or get from inside object

Question

I am new to OOP and have written a products class. All is working fine but I am unsure which of the below version of a method within this class is best?

The first gets the variables from within the object and the second passes the variables into the class. Both work. I originally had it as the first version but things seems to be running slow and then changed it to the second.

 public function getProductURLstart(){  

    $select = "SELECT l.URL, p.id FROM logins AS l
    INNER JOIN Pages AS p ON l.id = p.clientID 
    WHERE l.id = '$this->skID' AND p.productPage = 1";

    $res = mssql_query($select);
    $r = mssql_fetch_row($res);     

    $url = trim($r[0]); 
    $page_id = $r[1];

    return  $url .'/index.aspx?pageID='. $page_id . '&prodID=$this->prodID';

}

OR

 static function getProductURLstart($skID, $prodId){    

    $select = "SELECT l.URL, p.id FROM logins AS l
    INNER JOIN Pages AS p ON l.id = p.clientID 
    WHERE l.id = '$skID' AND p.productPage = 1";

    $res = mssql_query($select);
    $r = mssql_fetch_row($res);     

    $url = trim($r[0]); 
    $page_id = $r[1];

    return  $url .'/index.aspx?pageID='. $page_id . '&prodID=$prodId';

}

Are you using this in a loop. Which would be bad given the fact that you make a call to the DB for a just the page ID. Hopefully you store these in a cache, to prevent excessive calls to the DB for the same data. — b01
– b01, Commented Nov 29, 2011 at 15:24

b01 · Accepted Answer · 2011-11-29 15:29:01Z

1

If the instance of this class is for a single product, then use the first method,as there would be no reason to pass it in as parameters if you have them set when you construct the class.

Otherwise, if this is for more than on product, then the second method would be your best choice. As you will not have to call and set methods for the skID and prodID every time you need to get a product URL.

answered Nov 29, 2011 at 15:29

b01

4,4043 gold badges33 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

LeeTee Over a year ago

Yes I will have to call this multiple times, I first call the product class to get a list of all the products then loop through each product and call this method.

b01 Over a year ago

Can you get the page ID when you get the list of products? Otherwise you may want to beef up your 'getProductURLstart()' method to take a list of products and return results so that the product id is paired with the page ID in each resulting row. I personally would use a stored procedure for this particular part, instead of a simple quick select like your doing now. If you write it efficiently, bet things would speed up dramatically.

LostMohican · Accepted Answer · 2011-11-29 14:59:37Z

0

It depends, if you plan to give models some functionality like making them a little bit like active records, you can put the functionality in the class and use the class' members. Besides, do you have a good reason to use static functions? If you want to apply OOP, you have to give responsibilities to meaningful classes, a model should not both get data and do the redirection.

answered Nov 29, 2011 at 14:59

LostMohican

3,1447 gold badges33 silver badges42 bronze badges

Comments

user898741 · Accepted Answer · 2011-11-29 15:14:23Z

0

I'll be with the first. I always develop my app trying to use the less static methods I can and always using attributes, avoiding sending them by function parameters.

answered Nov 29, 2011 at 15:14

user898741

1 Comment

LeeTee Over a year ago

yeah - I thought that too, but as b01 mentions, I am calling this method multiple times in a loop and would therefore have to set $productObj->$prodId and $productObj->$skId every time I loop through each product.

Collectives™ on Stack Overflow

OOP php method - pass variables in or get from inside object

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related