If statement within an array declaration ...is that possible? [duplicate]

Question

Here is my code

$product_option_value_data[] = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    if (isset($product_option_value_description_query->row['smallimage'])) {
        'smallimage'                  => $product_option_value_description_query->row['smallimage'],
    }
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

can i do something like this....

here is my error

  Parse error: syntax error, unexpected T_IF, expecting ')' in /Users/mattelhotiby/Sites/posnation/shop_pos/catalog/model/catalog/product.php on line 419

Actually i did this

if (isset($product_option_value_description_query->row['smallimage'])) {
    $smallimage = $product_option_value_description_query->row['smallimage'];
}else{
    $smallimage = '';
}
$product_option_value_data[] = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    'smallimage'                  => $smallimage,
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

But I still want to know if there is a way to do an if within this array declaration.

you cannot put an if inside an array like that. why not just do it after your initial assignment? — Julien
– Julien, Commented Nov 30, 2011 at 17:06

Tom van der Woerdt · Accepted Answer · 2011-11-30 17:05:36Z

31

Not an if, but a similar thing is possible:

$product_option_value_data[] = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    'smallimage' => (isset($product_option_value_description_query->row['smallimage'])) ?
        $product_option_value_description_query->row['smallimage'] : null,
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

Syntax:

(<statement> ? <case: true> : <case: false>)
(1 == 1 ? 'yes!' : 'PHP is wrong')

answered Nov 30, 2011 at 17:05

Tom van der Woerdt

30.1k7 gold badges76 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Wiseguy Over a year ago

PHP docs: ternary operator

balkon_smoke · Accepted Answer · 2011-11-30 17:06:41Z

8

Maybe this one?

$array = array(
    'key1' => 'value1',
    'key2' => 'value2',
);

if (isset(...)) {
    $array['key3'] = 'value3';
}

$multiarray[] = $array;

answered Nov 30, 2011 at 17:06

balkon_smoke

1,2172 gold badges11 silver badges25 bronze badges

Comments

ioseb · Accepted Answer · 2011-11-30 17:05:47Z

2

In this case only possible option is to use following syntax:

'smallimage' => (isset($product_option_value_description_query->row['smallimage']) 
  ? isset($product_option_value_description_query->row['smallimage'])
    : NULL)

Though this has side effect, if your condition fails you will have "smallimage" key with value of NULL

answered Nov 30, 2011 at 17:05

ioseb

17k3 gold badges37 silver badges31 bronze badges

1 Comment

David Rhoden Over a year ago

I did like this answer, but the 'true' value of the ternary (here, "isset($product_option_value_description_query->row['smallimage'])" displayed a value of 1, for true. Change that to "$product_option_value_description_query->row['smallimage']" if you want the displayed value to be smallimage.

Darkry · Accepted Answer · 2011-11-30 17:06:14Z

2

You can define the array and then add some items:

$des = array(...);
if(...)
   $des["..."] = "...";

answered Nov 30, 2011 at 17:06

Darkry

5902 gold badges12 silver badges26 bronze badges

Comments

gustavotkg · Accepted Answer · 2011-11-30 17:06:20Z

1

No, You can do it inline or externaly:

$product_option_value_data[] = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    'smallimage'                  => @$product_option_value_description_query->row['smallimage'],
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

Or if smallimage cannot be empty:

$product_option_value_data[] = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

if (isset($product_option_value_description_query->row['smallimage'])) {
    $product_option_value_data['smallimage'] = $product_option_value_description_query->row['smallimage'];
}

answered Nov 30, 2011 at 17:06

gustavotkg

4,4392 gold badges22 silver badges29 bronze badges

4 Comments

Matt Elhotiby Over a year ago

what is the @$product_option_value_description_query->row['smallimage'], mean

gustavotkg Over a year ago

Lines prefixed by @ will not raise errors when notices occurs. So, if smallimage is not present in $product_option_value_description_query->row array, it will return null and no notice error will be shown

Aditya M P Over a year ago

Note however that if 'Scream' is enabled the suppression will be ignored.

Nishant Nair Over a year ago

For multi dimensional array do add the position to append the value i.e.

$product_option_value_data[sizeof($product_option_value_data-1)]['smallimage'] = $product_option_value_description_query->row['smallimage'];

David Nguyen · Accepted Answer · 2011-11-30 17:06:44Z

0

As far as I know, no. But why would you even do that, that is a bad idea. You should only be setting variables in an array, do you logic outside.

$data = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

if (isset($product_option_value_description_query->row['smallimage'])) {
    $data['small_image'] = $product_option_value_description_query->row['smallimage'];
}

$product_option_value_data[] = $data;

answered Nov 30, 2011 at 17:06

David Nguyen

8,5182 gold badges35 silver badges50 bronze badges

Comments

DaveRandom · Accepted Answer · 2011-11-30 17:07:18Z

NO. Simple as that.

Do:

$product_option_value_data[] = array(
    'product_option_value_id' => $product_option_value['product_option_value_id'],
    'name'                    => $product_option_value_description_query->row['name'],
    'price'                   => $product_option_value['price'],
    'prefix'                  => $product_option_value['prefix']
);

if (isset($product_option_value_description_query->row['smallimage'])) {
     $product_option_value_data[count($product_option_value_data) - 1]['smallimage'] = $product_option_value_description_query->row['smallimage'],
     // I'm not sure if you meant to have that [] in your declaration above
     // You may need to drop it, in which case the line would be:
     // $product_option_value_data['smallimage'] = $product_option_value_description_query->row['smallimage'],
}

dm03514 · Accepted Answer · 2011-11-30 17:07:27Z

0

Even if you could do that it is much more readable to add the conditional after or before the array.

answered Nov 30, 2011 at 17:07

dm03514

56.2k18 gold badges117 silver badges147 bronze badges

Collectives™ on Stack Overflow

If statement within an array declaration ...is that possible? [duplicate]

8 Answers 8

1 Comment

Comments

1 Comment

Comments

4 Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

1 Comment

Comments

1 Comment

Comments

4 Comments

Comments

Comments

Comments

Linked

Related