Multiple class inheritance?

Question

Based on the figure below, I wrote my code. enter image description here

This is the code I wrote:

#include<iostream>
#include<string>
using namespace std;

class person
{
private:
    int code;
    string name;
public:
    void    setCode(int c) { code=c; }
    int getCode()          { return code; }
    void setName(string s) { name=s; }
    string getName()       { return name; }
};

class account : public person
{
private:
    double pay;
public:
    void    setPay(double p) { pay=p; }
    double getPay()          { return pay; }
};

class admin : public person
{
private:
    string experience;
public:
    void setExper(string e) { experience=e; }
    string getExper()       { return experience; }
};

class master : public account, public admin
{
};

int main()
{
    master mastObj;// create master object.
    mastObj.setName("John");
    system("pause");//to pause console screen, remove it if u r in linux
    return 0;
}

The compiler showed these errors:

Error   1   error C2385: ambiguous access of 'setName'
Error   2   error C3861: 'setName': identifier not found    
Error   3   IntelliSense: "master::setName" is ambiguous

First of all, your question title is not an actual question, regardless of the question mark at the end of the sentence. Secondly, it is better to actually describe a problem, explain what you have tried so far, instead of just pasting a piece of code and have others fix it for you. — Aron Rotteveel
– Aron Rotteveel, Commented Dec 1, 2011 at 11:22
Your code formatting was a bit of a mess. Code is for humans too :) Especially since you want us to read it. — sehe
– sehe, Commented Dec 1, 2011 at 11:31
@sehe: I think it's safe to say that code is predominantly for humans :-) — Kerrek SB
– Kerrek SB, Commented Dec 1, 2011 at 11:53

Community · Accepted Answer · 2017-05-23 12:34:02Z

7

It is classic example of Diamond Problem in C++ when you use multiple inheritance.

The solution is : Virtual inheritance

That is, you should do this:

class account : public virtual person 
{                   //^^^^^^^note this
   //code
};

class admin : public virtual  person
{                  //^^^^^^^note this
   //code
};

I just found really good posts on this site, so I would redirect you to those answers here:

which also means, this topic should be voted for close.

edited May 23, 2017 at 12:34

CommunityBot

11 silver badge

answered Dec 1, 2011 at 11:22

Sarfaraz Nawaz

363k121 gold badges682 silver badges867 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sehe · Accepted Answer · 2011-12-01 11:40:05Z

3

You need virtual inheritance:

class account: public virtual person{
....
}

class admin: public virtual  person{
...
}

PS And your pay, code fields lack initialization! This could lead to embarassing errors (like paying the cleaner several million of dollars :)):

#include<iostream>
#include<string>
using namespace std;

class person
{
   // ...
   person() : code(0), name("anonymous") {}

};

class account : public virtual person
{
    // ...
    account() : pay(0) {}
};

class admin : public virtual person
{
    // ...
    admin() : experience("unknown") {}
};

edited Dec 1, 2011 at 11:40

answered Dec 1, 2011 at 11:22

sehe

400k49 gold badges475 silver badges673 bronze badges

Comments

db-hopper · Accepted Answer · 2020-09-08 11:56:37Z

0

you may use mastObj.master::admin::person::setName("John");

answered Sep 8, 2020 at 11:56

db-hopper

236 bronze badges

Collectives™ on Stack Overflow

Multiple class inheritance?

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related