unresolved external symbol when accessing a static variable

Question

class CommandManager {

public:
    void sendText(std::string command);
    static bool CommandManager::started;

private:


    bool parseCommand(std::string commands);

    void changeSpeed(std::vector<std::string> vec);
    void help(std::vector<std::string> vec);
};

And here's the client code:

CommandManager::started = true;

Linking these two files together I get:

1>UAlbertaBotModule.obj : error LNK2001: unresolved external symbol "public: static bool CommandManager::started" (?started@CommandManager@@2_NA)

1>C:\Development\School\cmput350-uofabot\UAlbertaBot\vs2008\Release\UAlbertaBot.dll : fatal error LNK1120: 1 unresolved externals

Where did I go wrong here?

possible duplicate of Unresolved external symbol on static class members — Joris Timmermans
– Joris Timmermans, Commented Dec 5, 2011 at 9:40
@KenLi: Try as I said in my answer. And let me know if you still face problem. — Sarfaraz Nawaz
– Sarfaraz Nawaz, Commented Dec 5, 2011 at 9:53
@KenLi - the other question is about the exact same issue - you declared but did not define your static in your class. — Joris Timmermans
– Joris Timmermans, Commented Dec 5, 2011 at 10:27

Sarfaraz Nawaz · Accepted Answer · 2011-12-05 09:42:29Z

25

You're doing that incorrectly.

class CommandManager {

public:
    void sendText(std::string command);
    static bool started; //NOT this -> bool CommandManager::started
    //...
};

then put the definition of static member in .cpp file as:

#include "CommandManager.h" //or whatever it is

bool CommandManager::started = true; //you must do this in .cpp file

Now you can use CommandManager::started in your client code.

answered Dec 5, 2011 at 9:42

Sarfaraz Nawaz

363k121 gold badges682 silver badges867 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Basile Starynkevitch · Accepted Answer · 2011-12-05 09:42:20Z

4

You should have inside your class:

class CommandManager {
 public:
  void sendText(std::string command);
  static bool started;
  //// etc
};

and outside your class, in a *.cc file (not in a *.hh header file), a definition like

bool CommandManager::started;

BTW, I believe you'll better make that private.

answered Dec 5, 2011 at 9:42

Basile Starynkevitch

231k18 gold badges323 silver badges578 bronze badges

Comments

Michael Krelin - hacker · Accepted Answer · 2011-12-05 09:41:43Z

2

Consider putting

bool CommandManager::started;

where you define other members.

answered Dec 5, 2011 at 9:41

Michael Krelin - hacker

144k25 gold badges200 silver badges177 bronze badges

Collectives™ on Stack Overflow

unresolved external symbol when accessing a static variable

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related