PHP function without subname return true or false

Question

I want to know if I can make a PHP function like function john(), without having any parameters. Do PHP functions always have to have a parameter like john($action)?

My script below won't work because of my empty action. Do I have to pass a NULL value as a parameter?

funcs.php

function is_customer_logged_in() {
    if($_COOKIE['HA_CUST_LOGIN'] == 1 && $_SESSION["loggedIn"]=="1"){
        return true;
    }else{
        return false;
    }
}

index.php

include("funcs.php");

if(is_customer_logged_in()) {
    echo 'logged in';
} else {
    echo 'not signed in';   
}

login-form.php

/* pseudo code, if form details
    match mySQL do this */

    $_SESSION["loggedIn"]="1";
    $_SESSION["userEmail"]=$username; //form variable
    $_SESSION["userID"]=$username; //form variable
    setcookie("HA_CUST_LOGIN", 1); // set a cookie and a session from a php salt db check
    echo '<script type="text/javascript">window.location="index.php"</script>';

    /* else go back to login-form.php */

Or do I have to return a string rather than a boolean?

Just blank. I think Session_Start(); might be an issue. In Classic ASP, crappy session_start(); are not needed to make the code Ugly — TheBlackBenzKid
– TheBlackBenzKid, Commented Dec 5, 2011 at 22:24
Setting $_COOKIE['HA_CUST_LOGIN'] == 1 is a complete waste of time as it can be easily spoofed. Just $_SESSION["loggedIn"]="1"; is enough — Dmitri Snytkine
– Dmitri Snytkine, Commented Dec 5, 2011 at 22:32
session_start() is only needed for when you want to enable session handling in your script. Otherwise, you can run scripts without session handling and save some processor time. Why take everything out of the toolbox when all you want is a screwdriver? — HorusKol
– HorusKol, Commented Dec 5, 2011 at 22:43

David Nguyen · Accepted Answer · 2011-12-05 22:19:53Z

2

No you do not need a parameter in your function, since you didn't declare one in your function. Echo out the variables, I bet you didn't do session_start() before setting the session variables.

answered Dec 5, 2011 at 22:19

David Nguyen

8,5182 gold badges35 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

TheBlackBenzKid Over a year ago

No I didn't actually. But I thought this is not needed since I am storing in a cookie too. Does session start need to go before EVERY code? Like at the top of funcs? As if I post the code with the redirect and echo the session it shows them via post. Not on the next page though. So they do not carry across on the redirect.

David Nguyen Over a year ago

SESSION exist no matter what until you close the browser, it should still be there even after a redirect. Yes you do need the session_start() at the start before you do anything session related.

HorusKol · Accepted Answer · 2011-12-05 22:50:38Z

1

You are trying to access a SESSION variable in the $_SESSION array. This variable will only be available on two conditions:

You have previously specified a value for $_SESSION['loggedIn']
(If the page/script has been requested again) you have called session_start() before trying to access the $_SESSION array() (and any output has been sent to the browser).

Even though you are using a COOKIE, you still need to call session_start() for your test to return evaluate true, because you have a logical AND in your IF statement:

if($_COOKIE['HA_CUST_LOGIN'] == 1 && $_SESSION["loggedIn"]=="1")

If session_start() has not been called, and the parameter $_SESSION["loggedIn"] has not been set, this IF statement will evaluate false. You should also be getting notices/warnings in your PHP logs (and in your browser if you are on a development machine) - if not, then you need to reconfigure your error reporting on you development machine.

answered Dec 5, 2011 at 22:50

HorusKol

8,75610 gold badges59 silver badges97 bronze badges

6 Comments

TheBlackBenzKid Over a year ago

So can I do this if(is_customer_logged_in()=="true")

HorusKol Over a year ago

not unless you start returning the string 'true' from your function instead of sending boolean true

TheBlackBenzKid Over a year ago

I have this working. I am just not confident with sessions for security. It feels uneasy to use if else headers now across the site for return member only pages.

HorusKol Over a year ago

Well - this is probably why you should be using some kind of page controller or front-facing controller. Otherwise, wrap all your security checks into a separate script and include that at the top of your pages - that way, you only have to write (and modify) the security logic in one place.

TheBlackBenzKid Over a year ago

What is a front-facing controller. The security checks are being built into a function now via a global header include. I am just just not happy with SESSION. I am sure Facebook likes dont use a simple session? There must be lots of things that are checked.

|

Collectives™ on Stack Overflow

PHP function without subname return true or false

2 Answers 2

2 Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related