Global variables are not coming to function

Question

I am using swfupload plugin. When I am trying to upload an image I want to pass two parameters but the parameters are not being passed.

                 var id1='g';
                var opt1='g';
       function getValues()
                {
                    id1 = $("#id").val();
                    opt1=$("#opt").val();
                    return id1.concat(opt1);
                }

             $(document).ready(function(){

             alert(getValues()); // Here coming

            $('#swfupload-control').swfupload({
                upload_url: "upload-file.php?para=getValues()",//Here not coming
                file_post_name: 'uploadfile',
                file_size_limit : "8024",
                file_types : "*.jpg;*.png;*.gif",
                file_types_description : "Image files",
                file_upload_limit : 10,
                flash_url : "js/swfupload/swfupload.swf",
                button_image_url : 'js/swfupload/wdp_buttons_upload_114x29.png',
                button_width : 114,
                button_height : 29,
                button_placeholder : $('#button')[0],
                debug: false
            })
            .bind('fileQueued', function(event, file){
                var listitem='<li id="'+file.id+'" >'+
                    'File: <em>'+file.name+'</em> ('+Math.round(file.size/1024)+' KB)         <span class="progressvalue" ></span>'+
                    '<div class="progressbar" ><div class="progress" ></div></div>'+
                    '<p class="status" >Pending</p>'+
                    '<span class="cancel" >&nbsp;</span>'+
                    '</li>';
                $('#log').append(listitem);
                $('li#'+file.id+' .cancel').bind('click', function(){
                    var swfu = $.swfupload.getInstance('#swfupload-control');
                    swfu.cancelUpload(file.id);
                    $('li#'+file.id).slideUp('fast');
                });
                // start the upload since it's queued
                $(this).swfupload('startUpload');
            })
            .bind('fileQueueError', function(event, file, errorCode, message){
                alert('Size of the file '+file.name+' is greater than limit');
            })
            .bind('fileDialogComplete', function(event, numFilesSelected, numFilesQueued){
                $('#queuestatus').text('Files Selected: '+numFilesSelected+' / Queued Files: '+numFilesQueued);
            })
            .bind('uploadStart', function(event, file){
                $('#log li#'+file.id).find('p.status').text('Uploading...');
                $('#log li#'+file.id).find('span.progressvalue').text('0%');
                $('#log li#'+file.id).find('span.cancel').hide();

            })
            .bind('uploadProgress', function(event, file, bytesLoaded){
                //Show Progress
                var percentage=Math.round((bytesLoaded/file.size)*100);
                $('#log li#'+file.id).find('div.progress').css('width', percentage+'%');
                $('#log li#'+file.id).find('span.progressvalue').text(percentage+'%');
            })
            .bind('uploadSuccess', function(event, file, serverData){
                var item=$('#log li#'+file.id);
                item.find('div.progress').css('width', '100%');
                item.find('span.progressvalue').text('100%');
                var pathtofile='<a href="uploads/'+file.name+'" target="_blank" >view &raquo;</a>';
                item.addClass('success').find('p.status').html('Done!!! | '+pathtofile);
            })
            .bind('uploadComplete', function(event, file){
                // upload has completed, try the next one in the queue

                $(this).swfupload('startUpload');

            })
        });
 });
    </script>

Adam Rackis · Accepted Answer · 2011-12-07 06:32:08Z

5

You have your function call in a string. You need to break the string and concatenate the function's results onto your string.

upload_url: "upload-file.php?para=getValues()"

becomes:

upload_url: "upload-file.php?para=" + getValues()

answered Dec 7, 2011 at 6:32

Adam Rackis

83.5k57 gold badges281 silver badges402 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

styfle · Accepted Answer · 2011-12-07 06:33:53Z

2

The line with the following code does not call the function getValues() because it is just a string.

upload_url: "upload-file.php?para=getValues()",

I'm assuming you want to call the function, not put "getValues()" in the url, correct?

answered Dec 7, 2011 at 6:33

styfle

25k30 gold badges93 silver badges142 bronze badges

2 Comments

Adam Rackis Over a year ago

+1, since that's happened to me more times than I can count :)

styfle Over a year ago

@user1021904: So just as Adam said, you need to concatenate the returned value of getValues() with the URL string. Make sure you keep the comma in there.

Collectives™ on Stack Overflow

Global variables are not coming to function

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related