PHP issue with classes

Question

I am having a little problem with the following code:

<?php
class appointments
{
    private $conn;

    function __construct($conn)
    {
        $this->conn = $conn;
    }

    function usercompany($uid)
    {
        return $this->conn->getone("SELECT company FROM signup WHERE UID = '".$uid."'");
    }

    function hastemplate($uid)
    {
        return $this->conn->getone("SELECT COUNT(parentid) FROM appointments_templates WHERE parentid = '$uid'");
    }

    function gettemplate($uid)
    {
        if($this->hastemplate($uid)){
            return $this->conn->getrow("SELECT * FROM appointments_templates WHERE parentid = '" . $uid . "'");
        } else {
            $appointment_template = 'This is a reminder to let you know that you have an appointment on {appointment} at '. $this->usercompany($uid);

            $sql = "INSERT INTO appointments_templates SET parentid = '" . $uid . "', content = '" . $appointment_template . "'";
            $this->conn->execute($sql);

            return $this->gettemplate($uid);
        }
    }  
}
?>

When I call usercompany($uid) by itself I get a correct result which is the users company. However when I call gettemplate($uid) the new template gets added to the database but without the results of usercompany($uid). Am I doing something wrong?

Edit: Regarding the INSERT syntax: http://milov.nl/2836

To recap: Issue is not that its not getting added to the database but rather than getting inserted as "This is a reminder to let you know that you have an appointment on {appointment} at XYZ Inc." its getting added as "This is a reminder to let you know that you have an appointment on {appointment} at "

can you put the code that uses this class ?

amrfaissal
– amrfaissal

2011-12-12 05:51:08 +00:00
Commented Dec 12, 2011 at 5:51 — amrfaissal
– amrfaissal, Commented Dec 12, 2011 at 5:51

icktoofay · Accepted Answer · 2011-12-12 05:28:16Z

3

insert statements do not work like that. Rather than:

insert into table set column1 = value1, column2 = value2

They work like this:

insert into table (column1, column2) values (value1, value2)

Additionally, I don't see any escaping going on, so I hope nobody has a company with an apostrophe in its name.

answered Dec 12, 2011 at 5:28

icktoofay

130k23 gold badges261 silver badges239 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Meisam Mulla Over a year ago

The issue is not that its not getting added to the database but rather the issue is its getting added as "This is a reminder to let you know that you have an appointment on {appointment} at" instead of "This is a reminder to let you know that you have an appointment on {appointment} at XYZ Inc." The company name is escaped when its stored in the database.

Manigandan Arjunan · Accepted Answer · 2011-12-12 05:44:29Z

0

it seems to be you have wrong syntax for insert query. You can refer the syntax for mysql insert query here http://www.w3schools.com/php/php_mysql_insert.asp

Try using this instead using single quotes,

$appointment_template = "This is a reminder to let you know that you have an appointment on {appointment} at ". $this->usercompany($uid)."";

edited Dec 12, 2011 at 5:44

answered Dec 12, 2011 at 5:34

Manigandan Arjunan

2,2651 gold badge25 silver badges43 bronze badges

5 Comments

Meisam Mulla Over a year ago

The issue is not that its not getting added to the database but rather the issue is its getting added as "This is a reminder to let you know that you have an appointment on {appointment} at" instead of "This is a reminder to let you know that you have an appointment on {appointment} at XYZ Inc."

Meisam Mulla Over a year ago

Also $appointment_template = "This is a reminder to let you know that you have an appointment on {appointment} at ". $this->usercompany($uid).""; doesnt work.

Manigandan Arjunan Over a year ago

try storing $this->usercompany($uid) in a variable and see whether the function returns any value. i mean inside the gettemplate .

Srisa Over a year ago

@MeisamMulla What is the return value of $this->usercompany($uid) ? Probably it is returning an empty string...

Meisam Mulla Over a year ago

It is the users company name. When I call $appointment->usercompany($uid) I get the correct result.

Collectives™ on Stack Overflow

PHP issue with classes

2 Answers 2

1 Comment

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related