PHP Private property visible outside of object (within same class)

Question

In this example, I have an abstract class and two regular classes. The abstract class is not supposed to be used alone, so its constructor is protected. Some functions are defined within the abstract class.

One of those functions is a "clone" function, which is supposed to return a new instance of the current object. This function makes a copy of the current object.

Here's my question:
When trying to set $copy->baz ([2] in clone()), it works, because I'm in the class that defined this private property. However, this doesn't make sense to me (at least in this example), because $copy is another object (of the same class) - is it possible to force PHP to use the magic setter ("Setting private property") when setting a private property of another object (not class)?

abstract class ac
{
    private $baz = "fakedefault";

    function __set($name, $value)
    {
        die("Setting private property!");
    }

    function clone()
    {
        $copy = clone $this; //make copy
        //Test:
        $this->baz = "newval"; //[1] Works as expected
        $copy->baz = "newval"; //[2] Does not die!
        return $copy; //return copy
    }
}

class c1 extends ac
{
    function foo()
    {
        print $this->baz;
    }
}

class c2 extends ac
{
    function foo()
    {
        print $this->baz;
    }
}

function dostuff()
{
    $o = new c1();
    $o->baz = "thiswontwork"; //Private -> doesn't work
}

please review my latest edit on my answer - I think it might help. thx — Tim G
– Tim G, Commented Dec 12, 2011 at 23:26

Tim G · Accepted Answer · 2011-12-12 23:26:27Z

1

You need to name your method __clone, not clone.

[edited to replace code]

try this:

<?

header( 'content-type: text/plain' );
abstract class ac
{
    private $name = 'default-value';

    public function __set($name, $value)
    {
        throw new Exception( 'Undefined or private property.' . $name );
    }

    function __clone()
    {
        // this does work - $this->name is private but is accessible in this class
        $this->name = 'Isaac Newton';
    }
}

class c1 extends ac
{

    function __clone()
    {
        // this does not work - $this->name is private to ac and can't be modified here
        $this->name = 'Isaac Newton';
    }

    function echoName()
    {
        echo $this->name;
    }
}

function dostuff()
{
    $o = new c1();
    //$o->otherVariable = 'test'; // won't work - it's undefined
    $a = clone $o;
}

dostuff();

edited Dec 12, 2011 at 23:26

answered Dec 12, 2011 at 22:56

Tim G

1,82212 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

thatwasbrilliant · Accepted Answer · 2011-12-12 22:46:10Z

0

$this->__set("baz", "newval");

answered Dec 12, 2011 at 22:46

thatwasbrilliant

5194 silver badges11 bronze badges

Collectives™ on Stack Overflow

PHP Private property visible outside of object (within same class)

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related