try catch to catch errors in .NET threadpool

Question

In an application I have I register to the EventLog.EntryWritten event, and a .NET Threadpool thread is used to wait for the change event to happen. I think an exception is occurring in this .NET Threadpool thread, so I want to use try/catch to make sure, like this:

try {
eventLog.EntryWritten += new EntryWrittenEventHandler(EventLogMonitor); 
}
catch (System.Componentmodel.Win32exception e)
{
// log error
}

I am just wondering if I have my try/ catch in the right place to monitor this thread for an exception?

where is it that you expect might throw? is it in the event subscription? or do you expect EventLogMonitor might throw? — Marc Gravell
– Marc Gravell, Commented Dec 14, 2011 at 16:04
I don't think you would get an exception trying to attach a method to the EntryWritten event. So the catch block may never fire. If you want to catch any exception that could happen in your code you can wrap the try block around the entire method/code area. so inside the EventLogMonitor method for example... This is not best practice at all btw. — user1231231412
– user1231231412, Commented Dec 14, 2011 at 16:07

Asher · Accepted Answer · 2011-12-14 16:05:01Z

6

the code you wrote will catch an exception on the registration to the event, not the event itself.

you should put the try..catch block in your EventLogMonitor method.

private void EventLogMonitor (Object sender,EntryWrittenEventArgs e)
{
     try
     { 
       // your logic goes here
     }
     catch (Exception ex)
     {
          //do something with the excpetion
     }

}

answered Dec 14, 2011 at 16:05

Asher

1,86715 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Polyfun Over a year ago

Because exceptions do not propogate across threads, you probably also want a way of passing the caught exception to your main thread. The main thread can then log it/rethrow it/display it etc.

Collectives™ on Stack Overflow

try catch to catch errors in .NET threadpool

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related