"unexpected T_VARIABLE" when creating string?

Question

I have been staring at this for 20 minutes now and I can't figure out what I'm doing wrong.

// Create query
$qry = "SELECT * FROM members WHERE member_id='"$_SESSION['SESS_MEMBER_ID']"'";
$result = mysql_query($qry);

Parse error: syntax error, unexpected T_VARIABLE in /home/dkitterm/public_html/test2/member-profile.php on line 24

If only you were using placeholders ... you would have 1) avoided this error entirely, 2) have cleaner looking code, 3) stopped potential injection attacks. See stackoverflow.com/questions/60174/… — user166390
– user166390, Commented Dec 15, 2011 at 0:12

user142162 · Accepted Answer · 2011-12-15 00:08:46Z

5

You need to concatenate the string literals with the variable with the . operator:

$qry = "SELECT * FROM members WHERE member_id='" . $_SESSION['SESS_MEMBER_ID'] . "'";

answered Dec 15, 2011 at 0:08

user142162

Sign up to request clarification or add additional context in comments.

Comments

cmbuckley · Accepted Answer · 2011-12-15 00:08:48Z

1

You need to concatenate your string:

$qry = "SELECT * FROM members WHERE member_id='" . $_SESSION['SESS_MEMBER_ID'] . "'";

answered Dec 15, 2011 at 0:08

cmbuckley

43.1k10 gold badges83 silver badges95 bronze badges

Comments

mario · Accepted Answer · 2011-12-15 00:14:14Z

1

The less cumbersome approach is using string interpolation. You're already in a double quoted string, so why not utilize its one distinct feature?

$qry="SELECT * FROM members WHERE member_id='{$_SESSION['SESS_MEMBER_ID']}'";

That's terser and less room for syntax errors.
See also http://php.net/manual/en/language.types.string.php#language.types.string.syntax.double (There's a shorter syntax even, if you read on.)

answered Dec 15, 2011 at 0:14

mario

146k20 gold badges243 silver badges293 bronze badges

Comments

Cyclone · Accepted Answer · 2011-12-15 00:09:20Z

0

Change it to:

 //Create query
 $qry="SELECT * FROM members WHERE member_id='" . $_SESSION['SESS_MEMBER_ID'] . "'";
 $result=mysql_query($qry);

You forgot the concatenation operator, .

answered Dec 15, 2011 at 0:09

Cyclone

18.4k47 gold badges130 silver badges196 bronze badges

Comments

robert petranovic · Accepted Answer · 2011-12-15 00:09:38Z

0

$qry="SELECT * FROM members WHERE member_id='" . $_SESSION['SESS_MEMBER_ID'] . "'";

You must concentrate your strings with . operator

answered Dec 15, 2011 at 0:09

robert petranovic

3413 silver badges5 bronze badges

Collectives™ on Stack Overflow

"unexpected T_VARIABLE" when creating string?

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related