how to see if a string contains a substring (objective-c)

Question

I want to see if a string, which is a title of a post on the apple rss news feed contains a substring, e.g. "Steve" or "Jobs". I organized the posts into a uitableview.

So there WAS a post which had Steve or Jobs in its title so I used this to check:

   if ([[entry title] localizedCaseInsensitiveCompare:@"Steve"] == NSOrderedSame ||        [[entry title] localizedCaseInsensitiveCompare: @"Jobs"] == NSOrderedSame) {

    NSLog(@"Comparism of Steve Jobs");
    cell.imageView.image = [UIImage imageNamed:@"steve.png"];
}

But it was never called, entry is an RSSItem class which contains the title - the entry and its title is not my problem, I have checked. My comparism is the problem. How do i compare

UPDATE!

Ok here is the code:

NSRange range = [[[cell textLabel] text] rangeOfString:@"Steve" options:NSCaseInsensitiveSearch];

if (range.location != NSNotFound) 
{
    cell.imageView.image = [UIImage imageNamed:@"steve.png"];


}

I have tried it other peoples way also but SAME RESULT:

some cells have their imageView as steve.png even though their title doesnt contain steve jobs. Weird??? I scroll down and when I go back up all the dequeued cells which are reallocated and initialized have the steve jobs picture. At starting when i open the app some cells which don't have steve in their title DO HAVE THE IMAGE, and then the above happens.

My surrounding code IF NEEDED:

  -(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {

UITableViewCell *cell = [tableView
                         dequeueReusableCellWithIdentifier:@"UITableViewCell"];
if (cell == nil) {
    cell = [[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault
                                   reuseIdentifier:@"UITableViewCell"]
            autorelease];
}


tableView.autoresizingMask = 5;
tableView.autoresizesSubviews = YES;
cell.autoresizingMask = 5;
cell.frame = CGRectMake(cell.frame.origin.x, cell.frame.origin.y, 20, 20);
RSSItem *item = [[channel items] objectAtIndex:[indexPath row]];
[[cell textLabel] setText:[item title]];
NSMutableString *string = [[NSMutableString alloc] initWithString:[[cell textLabel] text]];

if (string.length > 46) {
    cell.textLabel.numberOfLines = 2;
    UILineBreakMode lineBreak = UILineBreakModeClip;
    cell.textLabel.lineBreakMode = lineBreak;

}

[string release];

tableView.backgroundColor = [UIColor darkGrayColor];
cell.textLabel.font = [UIFont fontWithName:@"Arial Rounded MT Bold" size: 12.0];
cell.backgroundColor = [UIColor whiteColor];

NSRange range = [[[cell textLabel] text] rangeOfString:@"Steve" options:NSCaseInsensitiveSearch];

if (range.location != NSNotFound) 
{
    cell.imageView.image = [UIImage imageNamed:@"steve.png"];


    }



return cell;

    }

Please give the text of a few cells that falsely match "Steve". — Hot Licks
– Hot Licks, Commented Dec 18, 2011 at 15:12
And are you removing the image from recycled cells that are not "Steve"? It doesn't look like it to me. — Hot Licks
– Hot Licks, Commented Dec 18, 2011 at 15:14
Text of a few cells that falsely match steve: statement of apple board directors 100 million OSX Lion downloads in a day — user973985
– user973985, Commented Dec 18, 2011 at 23:08
then when i scroll back up all the recycled cells have the steve jobs image — user973985
– user973985, Commented Dec 18, 2011 at 23:09
"then when i scroll back up all the recycled cells have the steve jobs image" -- That's because you're not resetting the image in the recycled cells. (Try adding else { cell.imageView.image = nil; } at an appropriate place.) — Hot Licks
– Hot Licks, Commented Dec 18, 2011 at 23:23

Josh Rosen · Accepted Answer · 2015-11-22 03:29:36Z

12

NSString-rangeOfString returns an NSRange, which can be checked for the "not found" case.

if ([@"Some awesome string." rangeOfString:@"awesome"].location != NSNotFound)
{
  // awesome is in 'Some awesome string.'
}
else 
{
 // awesome is not in 'Some awesome string.' 
}

edited Nov 22, 2015 at 3:29

answered Dec 18, 2011 at 11:36

Josh Rosen

1,6861 gold badge12 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hot Licks Over a year ago

+1 Using the options:NSCaseInsensitiveSearch version accomplishes the OP's (apparent) goal of a case-insensitive search.

user973985 Over a year ago

for some reason this comparison gets called EVEN WHEN THAT IS NOT TRUE Check my updated question

Hot Licks · Accepted Answer · 2011-12-18 04:55:17Z

6

You're comparing the entire string, and "Steve Jobs" won't match either "Steve" or "Jobs". You probably want to use rangeOfString:@"Steve" options:NSCaseInsensitiveSearch, or some such.

answered Dec 18, 2011 at 4:55

Hot Licks

47.8k19 gold badges96 silver badges156 bronze badges

3 Comments

user973985 Over a year ago

but that won't tell me if Steve is located in the string

user973985 Over a year ago

that returns an NSRange nowhere close to what i want I basically want to FIND OUT IF Steve is inside the title so I can make the image of the imageView of the cell a picture of steve jobs

paulbailey Over a year ago

It does exactly what you want. If you read the documentation, it returns an NSRange of {NSNotFound, 0} if the string is not contained.

Fatima Arshad · Accepted Answer · 2014-09-24 17:59:14Z

2

If you are on iOS8 you can do this now as:

  NSString *stringToSearch = @"Steve";
  if ([stringToSearch containsString:@"Steve"])
  {
      NSLog(@"String contains Steve!!!");
  } 
  else 
  {
      NSLog(@"String does not contain Steve!!!");
  }

answered Sep 24, 2014 at 17:59

Fatima Arshad

3502 silver badges5 bronze badges

Comments

Hot Licks · Accepted Answer · 2011-12-19 02:37:09Z

1

"then when i scroll back up all the recycled cells have the steve jobs image"

That's because you're not resetting the image in the recycled cells. (Try adding

else { 
    cell.imageView.image = nil; 
}

at an appropriate place.)

answered Dec 19, 2011 at 2:37

Hot Licks

47.8k19 gold badges96 silver badges156 bronze badges

Collectives™ on Stack Overflow

how to see if a string contains a substring (objective-c)

4 Answers 4

2 Comments

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related