PHP login function not working when I enable sha1

Question

I have a PHP page that registers and logs in users. When I enable sha1, the user gets created and the encrypted password is stored in the DB, but they cannot log in. When I comment out the line to encrypt in both the user creation section as well as the login section, everthing works. Here is my code to create the user:

function add_member($nick_name, $email_address, $password) {
    global $db;
    $password = sha1($password);
    $query = "INSERT INTO members
                  (nick_name, email_address, password)
              VALUES
                  ('$nick_name', :email_address, :password)";
    $statement = $db->prepare($query);
    $statement->bindValue(':email_address', $email_address);
    $statement->bindValue(':password', $password);
    $statement->execute();
    $statement->closeCursor();
}

Here is my code to validate the user:

function is_valid_member($email_address, $password) {
    global $db;
    $password = sha1($password);
    $query = "SELECT member_ID 
              FROM members
              WHERE email_address = :email_address AND password = :password";
    $statement = $db->prepare($query);
    $statement->bindValue(':email_address', $email_address);
    $statement->bindValue(':password', $password);
    $statement->execute();
        $valid = ($statement->rowCount() == 1);
    $statement->closeCursor();
    return $valid;
}

Again, when I comment out the "$password = sha1($password);" in both sections, everything works but the password is clear text.

Thanks!

I am trying "test" "test" all lower case. Here is an update: When I change $password = sha1($password) to $password = MD5($password), that works perfectly. — Progger
– Progger, Commented Dec 22, 2011 at 5:23
That's interesting. What happens if you dump the sha1()'d values before you use them in your query? Are they different? — alex
– alex, Commented Dec 22, 2011 at 5:26
Did the user you are adding already exist and you just do not realize it do to the lack of errors? — Stefan H
– Stefan H, Commented Dec 22, 2011 at 5:28

Robin Michael Poothurai · Accepted Answer · 2011-12-22 05:47:55Z

2

try to debug like this, echo your $password = sha1($password); and check your database entry, might be your datatype length truncated some text in stored password

answered Dec 22, 2011 at 5:47

Robin Michael Poothurai

5,6947 gold badges26 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Progger Over a year ago

That was my problem. My datatype length was not long enough for sha1. That is why MD5 was working and sha1 was not. Thank you!

Collectives™ on Stack Overflow

PHP login function not working when I enable sha1

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related