Php is messing up my javascript, button won't open

Question

I have a javascript button on my site that is supposed to popup a URL at random from an external txt file of urls (one per line) but the php keeps messing up the javascript by inserting an extra break.

 <a href="#" onClick="javascript:window.open('http://something.com/a.php?u=<?php echo $url ?>', 'yea', 'height=520, width=400, location=no, menubar=no, resizable=no, scrollbars=no, status=no, titlebar = yes, toolbar=no');"><img src="clic.jpg" border="0"></a>

<?php 

$urls = @file('urls.txt');
$num = count($urls)-1;
$url = $urls[rand(0,$num)];

?>

if that echo is the only statement inside the php code block the ; can be omitted — redDevil
– redDevil, Commented Jan 11, 2012 at 18:40
This code is exactly as you posted? because you are echoing $url before you assign a value to it. — Petruza
– Petruza, Commented Jan 11, 2012 at 18:45
Also if you pass the url as a GET parameter remember to encode it properly. — dfsq
– dfsq, Commented Jan 11, 2012 at 18:47

Petruza · Accepted Answer · 2012-01-11 18:47:45Z

1

Use file() like this:
@file( 'urls.txt', FILE_IGNORE_NEW_LINES );

answered Jan 11, 2012 at 18:47

Petruza

12.4k26 gold badges91 silver badges146 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jasonbar · Accepted Answer · 2012-01-11 18:38:54Z

0

file() reads the entire file in to an array WITH the newlines still attached.

Try this:

$url = trim($urls[rand(0,$num)]);

answered Jan 11, 2012 at 18:38

jasonbar

13.5k4 gold badges41 silver badges47 bronze badges

Comments

Hossein · Accepted Answer · 2012-01-11 18:39:32Z

0

Try this:

$url = trim($urls[rand(0,$num)]);

Each line has the CR (and LF) characters that mark a new line at its end. The trim function will remove such extra whitespace characters from the string.

answered Jan 11, 2012 at 18:39

Hossein

4,1652 gold badges26 silver badges46 bronze badges

Comments

redDevil · Accepted Answer · 2012-01-11 18:39:56Z

0

<?php 

$urls = @file('urls.txt');
$num = count($urls)-1;
$url = $urls[rand(0,$num)];
$url = trim($url);
?>

answered Jan 11, 2012 at 18:39

redDevil

1,91917 silver badges25 bronze badges

Collectives™ on Stack Overflow

Php is messing up my javascript, button won't open

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related