mysql query and implode

Question

I try to retrieve a array from one table What is wrong with this code?

$_fbexclude = mysql_query("SELECT fbempfang FROM fbinvite WHERE fbreturn = '1' ");
$fbexcludearray= mysql_fetch_array($_fbexclude);

// Convert the array 
$excludes = implode(',', $fbexcludearray);

From echo $excludes; It only gives me just the following response: 1000033xxx161,1000033xxx161 Twice the same fbempfang

You're fetching the rows only once, therefore it creates an array of only one element $fbexcludearray["fbempfang"]. This may cause the problem (i suppose you want to get an array of ALL the rows) — Vultour
– Vultour, Commented Jan 15, 2012 at 0:36

DaveRandom · Accepted Answer · 2012-01-15 00:41:43Z

5

See if the following gives you what you want (FIXED):

$_fbexclude = mysql_query("SELECT fbempfang FROM fbinvite WHERE fbreturn = '1'");
$fbexcludearray = array();
while ($row = mysql_fetch_assoc($_fbexclude)) {
  $fbexcludearray[] = $row['fbempfang'];
}

// Convert the array 
$excludes = implode(',', $fbexcludearray);

mysql_fetch_array() and it's siblings (_assoc, _row) only retrieve one row at a time. This means that your original code will only give you the first returned row - to work around this, we use the loop you see above.

The reason you see the same data twice is because mysql_fetch_array() returns a mixed indexed and associative array, which contains all the data twice over. For this reason, it is much better to use mysql_fetch_assoc() or mysql_fetch_row(), as you rarely need both formats.

In fact, it is much better to use mysqli, but the same information applies to that as well.

answered Jan 15, 2012 at 0:41

DaveRandom

88.8k11 gold badges159 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

adventistapr Over a year ago

Fantástico, justamente o que estava procurando e precisando, esse post resolveu a minha vida, obrigado @DaveRandom.

brasofilo · Accepted Answer · 2014-06-03 09:20:07Z

3

Use right SQL query:

SELECT GROUP_CONCAT(`fbempfang`) as imploded from `fbinvite`  WHERE fbreturn = '1'

It's return string as PHP implode(',', array(…));

edited Jun 3, 2014 at 9:20

brasofilo

26.2k15 gold badges96 silver badges189 bronze badges

answered Jun 3, 2014 at 8:23

Gedweb

7321 gold badge8 silver badges22 bronze badges

Comments

Treffynnon · Accepted Answer · 2012-01-15 00:43:25Z

1

Try this on for size:

$implode_arr = array();
$_fbexclude = mysql_query("SELECT fbempfang 
                           FROM fbinvite 
                           WHERE fbreturn = '1'");
while($row = mysql_fetch_array($_fbexclude)) {
    $implode_arr[] = $row['fbempfang'];
}

// Convert the array 
$excludes = implode(',', $implode_arr);

You need to loop over the mysql_fetch_* functions because they only return one of the result rows at a time. For more information and examples see the manual page for mysql_fetch_assoc().

answered Jan 15, 2012 at 0:43

Treffynnon

21.6k6 gold badges68 silver badges99 bronze badges

Collectives™ on Stack Overflow

mysql query and implode

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related