Display viewdata in asp.net 4.0 mvc

Question

What ia m trying to do is display a success message after the query has been executed succesfully on database. Everything is working fine except my viewdata which does not display anything on view page. Not sure why. Below is my code please help me guys.

public class SearchItem
{
    [Required(ErrorMessage = "Required Field")]
    public string searchItem { get; set; }
}


    public ActionResult Index()
    {
        try
        {
            ViewData["SuccessMessage"] = "";
            return View();
        }
        catch (Exception ex)
        {
            return View("EmptySearch");
        }
    }

    [HttpPost]
    public ActionResult Index(string searchItem)
    {
        try
        {
             ............
            //database query with searchItem
            ...............

            string suceesstring = "A WAREHOUSE HOLD has been added.";
            ViewData["SuccessMessage"] = suceesstring;
            return View();
        }
        catch (Exception ex)
        {
            return View("EmptySearch");
        }
    }

And here is my view page:

@model KeleIntegratedTools.Models.SearchItem

@{
    ViewBag.Title = "Great Plains hold Insert Utility";
    Layout = "~/Views/Shared/_Layout.cshtml";
}

< h2>Great Plains hold Insert Utility</h2>
< p class ="PenColor" >
Please enter order number to place on warehouse hold.

@using (Html.BeginForm("Index", "GreatPlains"))

{

< div>
    < fieldset>
        < legend>Order Information</legend>

        <div class="editor-label">
            @Html.Label("Order Number")

            @Html.TextBox("searchItem")
            @Html.ValidationMessageFor(m => m.searchItem)
            @Html.Label(ViewData["SuccessMessage"].ToString())
        </div>
        <p>
            <input type="submit" value="Search" />
        </p>
    </fieldset>
</div>
}

archil · Accepted Answer · 2012-01-17 16:11:33Z

9

You are using wrong method. First parameter of Label method is the name of property of model. And it generates html label with attribute for="parameterValue", not the label with that text. To display message to user, you should do it like

@ViewData["SuccessMessage"]

Also, take a look at TempData property

answered Jan 17, 2012 at 16:11

archil

39.6k7 gold badges69 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

14578446 Over a year ago

thanks @archil, dis small problem was bugging me since long n being a beginner in mvc was not able to get it. thanks n appriciate your help :)

RickAndMSFT Over a year ago

Additionally you should be using ViewBag, not ViewData. Please go through my intro to MVC, the the EF/MVC tutorials at asp.net/mvc

archil Over a year ago

@RickAnderson-MSFT actually, he should not use ViewBag/ViewData at all. For message display, as I indicated, he should use TempData. in all the other cases, ViewModels only.

Kevin Junghans · Accepted Answer · 2012-01-17 16:45:06Z

1

The problem is how you are using the Html Helper method Label. The first argument is always an expression that indicates the properties to display. The second optional argument is the text to display. If you change it to the following the text in your ViewData will display.

@Html.Label("", ViewData["SuccessMessage"].ToString())

answered Jan 17, 2012 at 16:45

Kevin Junghans

17.6k4 gold badges48 silver badges62 bronze badges

Comments

Raviteja V · Accepted Answer · 2018-10-25 12:10:24Z

0

Here i am providing some example to get better understanding.

inherent your models here @using Mvc Project.Models

@{ load into variable View Data["Student"] as Your Own Model; }

" @object.Name" display between the tags

**

answered Oct 25, 2018 at 12:10

Raviteja V

4655 silver badges11 bronze badges

Collectives™ on Stack Overflow

Display viewdata in asp.net 4.0 mvc

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest