What's wrong in this code?

Question

I was trying to mimic strtok functionality but getting segmentation fault. Please help me out here.

Here is my code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main(int argc, char argv[])
{
    int i=0;
    char c[]="get the hell out of here";
    char *p;
    char *temp=(char *)malloc(100);
    while(c[i]!='\0')
    {
        if(c[i]!=' ')
        {
            *temp=c[i];
            temp++;
            i++;
        }
        else
        {
            *temp='\0';
            printf("printing tokenn");
            puts(temp);
            i++;
            temp="";
        }
    }
    return 0;
}

@dreamlax void main is actually okay, Shashank can you please move #include into code and format it properly? And what do you mean by line temp="";? — Vyktor
– Vyktor, Commented Jan 31, 2012 at 1:14
@Vyktor: void main might work in practice, but it's not legal. — jamesdlin
– jamesdlin, Commented Jan 31, 2012 at 1:15
@jamesdlin: under C89, void main could be allowed. But regardless, it's not a good idea. — Joe
– Joe, Commented Jan 31, 2012 at 1:27
An implementation may permit void main(). If you're using a compiler that doesn't support and document it, then the program's behavior is undefined. Unless you're compiling for a freestanding implementation, there is no good reason to use void main(). — Keith Thompson
– Keith Thompson, Commented Jan 31, 2012 at 1:31
@Vyktor: This was discussed on StackOverflow before, here, where it was found that the C and C++ standard actually require int as the return type. The only implementation-defined aspect of main are the arguments. — dreamlax
– dreamlax, Commented Jan 31, 2012 at 1:51

David Schwartz · Accepted Answer · 2012-01-31 01:13:24Z

8

temp="";

This causes temp to point at unmodifiable memory, leading to a fault the next time you try to modify through it. You wanted to restore temp to the value you got from malloc (which you forgot to save).

answered Jan 31, 2012 at 1:13

David Schwartz

184k18 gold badges229 silver badges293 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

What's wrong in this code?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related