how to create static class List property inside static class

Question

I have created following class:

       public static class Current
        {
            public static class User
            {
                public static int UserID { get; set; }
                public static string UserName { get; set; }
                public static List<UserRole> Role { get; set; }
            }
            public static class UserRole
            {
                public static int RoleID { get; set; }
                public static string RoleName { get; set; }
            }
       }

But it will gives me an error: in this line

public static List<UserRole> Role { get; set; }

Error 1 'Framework.Security.Current.UserRole': static types cannot be used as type arguments

Jon Skeet · Accepted Answer · 2012-02-01 08:42:01Z

8

This has nothing to do with where you're trying to use the class - it has everything to do with the fact that you can't use a static class as a type argument. Given that you can't create an instance of a static class, how could a List<UserRole> ever be useful?

I strongly suspect that those classes shouldn't be static classes to start with - why on earth would you want them to be?

(It's also not clear why they should be nested classes, but that's a different matter.)

answered Feb 1, 2012 at 8:42

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

imdadhusen Over a year ago

Actually my requirement is like i have a User which contain List of Roles and i would like access this current user to entire application without creating instance of that. Please suggest best solution for the same. your answer would be appreciated!!

Jon Skeet Over a year ago

@imdadhusen: Well, aside from the fact that I would question the wisdom of that design in the first place (statics tend to make testing hard, for one thing) just because the list variable is static doesn't mean the class (UserRole) has to be static. If you want instances of roles, it can't be static - and if you want each instance to have a different RoleID and RoleName, those shouldn't be static either. How confident are you in your understanding about what static means? It sounds like you may be a little confused.

Jeff Galvao · Accepted Answer · 2012-07-17 10:03:18Z

I understand what you are trying to do. (although you're kind of going the wrong way about it.) The only Static Class should be User and they should not be Nested. There are a few other issues with your design but in the end everyone works differently.

This is one way you could have a List within a Static Class.

        public static class CurrentUser           
        {              
            public static int UserID { get; set; }              
            public static string UserName { get; set;   }


            public static List<UserRole> Role()
            {
                //Call another class with method to fill the list
                AnotherClass _anotherClass = new AnotherClass();
                return _anotherClass.Roles();

            }
        }

Then have a non-static UserRole

public  class UserRole         
        {              
        public  int RoleID { get; set; }     
        public  string RoleName { get; set; }      
        }

And the class where you retrieve your data from should contain a method to fill the List

            public class AnotherClass
        {
            public List<UserRole> Roles()
            {
                 List<UserRole> outList = new List<UserRole>();
                 //Fill the List with your UserRoles
                 foreach (object MyData in MyDataList)
                 {
                     UserRole myRole = new UserRole();
                     outList.Add(myRole);
                 }

                 return outList;
            }

        }

Teudimundo · Accepted Answer · 2012-02-01 08:45:50Z

0

The problem here is that you cannot use UserRole as a type for the List. Since it is a static class it would not make really sense. A list is made of objects that are instances of a class. There is no such thing as an instance for static class.

You should reconsider your design, you have some serious flaw in it.

answered Feb 1, 2012 at 8:45

Teudimundo

2,6901 gold badge21 silver badges28 bronze badges

1 Comment

imdadhusen Over a year ago

Actually my requirement is like i have a User which contain List of Roles and i would like access this current user to entire application without creating instance of that. Please suggest best solution for the same. your answer would be appreciated!!

Collectives™ on Stack Overflow

how to create static class List property inside static class

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related