Print each value of a delimited string as an HTML list item

Question

I have input like this:

$recipe['ingredients'] = '100ml milk, 350ml double cream, 150ml water';

I'm trying to split it up so it looks as follows:

<ul>
    <li>100ml milk</li>
    <li>350ml double cream</li>
    <li>150ml water</li>
</ul>

So far I have the following code:

$ingredientsParts = explode(',', $row_rs_recipes['ingredients']);
$ingredients = array($ingredientsParts);
while (! $ingredients) { 
   echo" <li>$ingredients</li>";
}

but nothing gets printed.

PHP's explode() returns an array: php.net/manual/en/function.explode.php — bzx
– bzx, Commented Feb 8, 2012 at 9:07
$ingredients = array($ingredientsParts); You don't need this. ingredientsParts is already an array after explosion. I would, personally, use for or foreach loop to traverse whole array but that's up to you. I'm not sure if it could be done by this while condition. Are you trying to reference to array internal pointer by !$ingredients? — Jovan Perovic
– Jovan Perovic, Commented Feb 8, 2012 at 9:07

Oyeme · Accepted Answer · 2012-02-08 09:08:16Z

3

$ingredientsParts = explode(',', $row_rs_recipes['ingredients']);
    $li = '<ul>';
    foreach($ingredientsParts as $key=>$value){
         $li.=" <li>$value</li>";
    }
    $li.= '</ul>';

echo $li;

answered Feb 8, 2012 at 9:08

Oyeme

11.3k4 gold badges46 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

mickmackusa Jan 27 at 23:10

This answer is missing an educational explanation. $key is declared but never accessed. It seems strange to declare a variable as $li when it contains <ul> element data.

boobiq · Accepted Answer · 2012-02-08 09:05:20Z

2

this should be enough:

$ingredientsParts = explode(', ', $row_rs_recipes['ingredients']);

foreach ($ingredientsParts as $ingredient)
{ 
    echo "<li>$ingredient</li>";
}

or you can explode it by ',' and use echo '<li>' . trim($ingredient) . '</li>'; to remove whitespace from beginning/end of that string

answered Feb 8, 2012 at 9:05

boobiq

3,0242 gold badges22 silver badges27 bronze badges

Comments

Sameera Thilakasiri · Accepted Answer · 2012-02-08 09:05:38Z

1

When you explode() a string it is automatically converted into an array. You do not need to convert it to an array type as you did on the second line.

You want to use a foreach() loop to iterate through an array, not a while loop.

   $ingredientsAry = explode(',', $row_rs_recipes['ingredients']);
   foreach($ingredientsAry as $ingredient){
       echo "<li>$ingredient</li>";
   }

In fact you can just do a foreach() loop on the explode() value

foreach(explode(',', $row_rs_recipes['ingredients']) as $ingredient){
    echo "<li>$ingredient</li>";
}

answered Feb 8, 2012 at 9:05

Sameera Thilakasiri

9,51810 gold badges54 silver badges87 bronze badges

2 Comments

bzx Over a year ago

you forgot the space after a comma

Yoshi Over a year ago

@bzx It's saver to split only on the , as this is the separating char. Imaging the string foo, bar,foobar, if the space was included this string would not be split properly.

Maxime · Accepted Answer · 2012-02-08 09:09:23Z

0

The explode method already return an array, so you don't have to transform your variable $ingredientsParts into an array.

Just do:

$ingredientsParts = explode(', ', $row_rs_recipes['ingredients']);
foreach ($ingredientsParts as $ingredient)
{ 
echo "<li>$ingredient</li>";
}

answered Feb 8, 2012 at 9:09

Maxime

2351 gold badge2 silver badges12 bronze badges

Comments

xdazz · Accepted Answer · 2012-02-08 09:10:06Z

0

if (!empty($recipe['ingredients'])) {
    echo '<ul><li>' . implode('</li><li>', explode(', ', $row_rs_recipes['ingredients'])) . '</li></ul>';
}

answered Feb 8, 2012 at 9:10

xdazz

161k38 gold badges255 silver badges278 bronze badges

Comments

jidesakin · Accepted Answer · 2016-07-28 11:47:18Z

0

You can do this:

$ingredients = explode(',', $row_rs_recipes['ingredients']);

$list = '<ul>';

foreach ($ingredients as $ingredient) 
{
   $list .= '<li>' . $ingredient . '</li>';
}
$list .= '</ul>';

echo $list;

answered Jul 28, 2016 at 11:47

jidesakin

3593 silver badges8 bronze badges

Collectives™ on Stack Overflow

Print each value of a delimited string as an HTML list item

6 Answers 6

1 Comment

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related