Errorhandling in node.js

Question

I want to create a mongoID using an URI fragment as source. However, unless the URI really contains a properly formatted mongoId, I get the below error thrown.

What should I change to allow _id creation without throwing errors as wrapping it in a try/catch block doesn't do it?

Error:

500 Error: Argument passed in must be a single String of 12 bytes or a string of 24 hex characters in hex format

The code:

var _id = db.bson_serializer.ObjectID.createFromHexString(req.params.id);

this.db.users.findById(_id, function(err, doc) {
    if (!err && !!doc) { res.send(JSON.stringify(doc)); } else {res.send(JSON.stringify({error: "Not found"));}
});

I use the mongoskin driver.

I'm pretty sure I understand what you're trying to, but can you show a sample URI? — JP Richardson
– JP Richardson, Commented Feb 21, 2012 at 17:24
/users/nonvalidid - throws error. /users/47cc67093475061e3d95369d - valid. — Industrial
– Industrial, Commented Feb 21, 2012 at 17:26

JP Richardson · Accepted Answer · 2012-02-21 17:38:44Z

2

The error is being thrown on this line:

var _id = db.bson_serializer.ObjectID.createFromHexString(req.params.id);

If you wrap that in try/catch block it should work.

var _id = null
try {
  _id = db.bson_serializer.ObjectID.createFromHexString(req.params.id);
} catch (err) {
  res.send(JSON.stringify({error: "Not found"}));
  return;
}

this.db.users.findById(_id, function(err, doc) {
  if (!err) { 
    res.send(JSON.stringify(doc)); 
  } else {
    res.send(JSON.stringify({error: err.message}));
  }
});

Does this work for you?

answered Feb 21, 2012 at 17:38

JP Richardson

39.6k36 gold badges123 silver badges152 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Errorhandling in node.js

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related