jQuery refactored function

Question

I like to keep my code as DRY as possible and would like to know if the following is possible. I'll need to reuse the code below many times with the only difference being what I do in the following function.

.on("click", "a", function(e) {})

I could just duplicate the addToBooking function, give it a different name, make the slight change in the click handler but that feels wasteful and repetitive.

Can I perhaps pass a code block to the addToBooking function? Or maybe there's another cool, efficient way I'm not aware of.

The full code block

var addToBooking = function(that, event) {
  var left, top;

  event.stopPropagation(); 

  //Turn off all calendar tracking
  $(".track").off(); 

  //Get proper sticky positioning (Checks to make sure it wont display off screen)
  left = getPosition(".add_to_booking", "left");
  top = getPosition(".add_to_booking", "top");

  //Position sticky, display and listen for click event to see what to do next
  $(".add_to_booking").css({top: top, left: left})
                      .fadeIn('fast')
                      .on("click", function(e) { e.stopPropagation(); })
                      .on("click", "a", function(e) {
                        if($(this).text() === "YES") {
                          //Close dialog
                          closeTT();

                          //Open new add to booking box
                          addBooking(that, event);

                        } else {
                          closeTT();
                        }
                      });
}

epascarello · Accepted Answer · 2012-02-23 13:31:39Z

2

Pass in the function and assign it

var addToBooking = function(that, event, custFnc) {
    ...
    ...
    .on("click", "a", custFnc );
}

Fiddle

To pass parameters, you need to use call()

jQuery( function(){

    function hey(evt, test){ 
        var text = jQuery(this).text();
        alert(text + ":" + test);
    }


    function addClick( custFnc ){ 
        var test=99;
        jQuery("#foo").on("click", 
            function(e){ 
                custFnc.call(this, e,test); 
            } 
        );
    }

    addClick(hey);
});

Fiddle

edited Feb 23, 2012 at 13:31

answered Feb 23, 2012 at 3:51

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

EasyCo Over a year ago

In your example, how would I pass variable from that function? See here, it doesn't work but you get the idea: jsfiddle.net/SqZm4/1

Collectives™ on Stack Overflow

jQuery refactored function

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related