Exit from anonymous function. jQuery

Question

I have a problem. I have following code in anonymous function:

        ...
        if (fillActyalizerForm(jQuery(this).attr('account_id'), jQuery(this).attr('currency_id')) == false) {
            return false;
        }
        jQuery("#actyalizer").slideToggle("slow");
        ...

THe problem is even if I return false, element slides down.

function fillActyalizerForm(account_id, currency_id) {
    formValues = {};
        jQuery.ajax({
            async: false,
            type: 'POST',
            url: "..",
            data: "{'accountId':" + account_id + ",'currencyId':" + currency_id + "}",
            dataType: "json",
            contentType: "application/json; charset=utf-8",
            success: function (data) {
                if (data && data.hasOwnProperty("d")) {
                    data = data.d;
                }
                if (!data.Error) {
                    formValues = data;
                    delete formValues.Error;
                } else {
                    alert('<%=Resources.app.Actyalizer_AcLoadFail %>');
                    return false;
                }
            },
            error: function (data) {
                alert('<%=Resources.app.Actyalizer_AcLoadFail %>');
                return false;
            }
        });

So I am successfully get alert message, but it still slides down the elemtn.

To expand on what @mindandmedia said, check for errors raised by the fillActyalizerForm function in your console. — Rory McCrossan
– Rory McCrossan, Commented Feb 25, 2012 at 11:21
@mindandmedia,@Rory McCrossan how to make sub-function return false? I'v tried try-catch, but it is failed. — Jevgeni Smirnov
– Jevgeni Smirnov, Commented Feb 25, 2012 at 11:38

Philip Fourie · Accepted Answer · 2012-02-25 11:51:19Z

1

The problem is that the fillActyalizerForm function executes the asynchronous .ajax method and then returns without specifying a return value (the default return value is then false).

I think you have two choices:

Move the jQuery("#actyalizer").slideToggle("slow"); into the success function.
Do a synchronous ajax request.

I would recommend option one. This can be achieved by passing your function as a parameter to fillActyalizerForm or physically move the code.

answered Feb 25, 2012 at 11:51

Philip Fourie

118k11 gold badges69 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jevgeni Smirnov Over a year ago

i think ill wull use second option

Philip Fourie Over a year ago

@JakeFisher, be aware of the disadvantages when using synchronous AJAX calls, it blocks the UI thread! Research it and make sure that is what you really want.

Jevgeni Smirnov Over a year ago

Fourie yes you was right about first option. This was more preferrable.

Collectives™ on Stack Overflow

Exit from anonymous function. jQuery

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related