Javascript/Jquery get num row from a string

Question

I have a textarea. I would count lines of my input.

My simple countLines function works with all other regex, but not in this case.

function countLines(str){
  return (str.split("\r\n|\r|\n").length -1);
}

alert( countLines($("#myTextArea").html() );

Why its return is 0 even if I have multiple lines of text?

gilly3 · Accepted Answer · 2012-02-28 00:44:42Z

2

You are passing in a string to .split() instead of a regex. Use slashes (not quotes) to delimit your regex: /\r\n|\r|\n/.

function countLines(str){  
  return (str.split(/\r\n|\r|\n/).length -1);  
}

But, subtracting 1 from the length will only be correct if your textarea is empty. In the case that your textarea contains:

line 1
line 2

There will only be one \n. Calling .split() will return a two-item array and countLines() will return 1 when there are actually two lines, right?

answered Feb 28, 2012 at 0:44

gilly3

92.7k26 gold badges148 silver badges179 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jasper Over a year ago

Note that .html() will not return user input, for that you have to use .val(). Here is a simple demo to show the difference between using .html() and .val() on a textarea: jsfiddle.net/YZVP6

score 2 · Accepted Answer · 2012-05-07 02:22:33Z

2

Don't use split. Here's an even better way since you'll probably be working with a DOM element. The example below counts the lines of code in a "pre" element. Substitute "pre" for any selector desired. Enjoy.

var count = $('pre').text().match(/\r?\n|\r/mg).length;

edited May 7, 2012 at 2:22

answered May 7, 2012 at 2:11

user1248475

Comments

Daniel A. White · Accepted Answer · 2012-02-28 00:43:16Z

1

You probally want the regex form.

function countLines(str){
   return (str.split(/\r?\n|\r/).length);
}

answered Feb 28, 2012 at 0:43

Daniel A. White

192k49 gold badges389 silver badges474 bronze badges

Collectives™ on Stack Overflow

Javascript/Jquery get num row from a string

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related