How to email users in multiple arrays, the Rails way?

Question

I have a Project that has three arrays:

admins
members
readers

I want to email the various users in each of those arrays. Am currently doing it like:

@project.admins.each do |u|
  ProjelementMailer.notify_update(u)
end

@project.members.each do |u|
  ProjelementMailer.notify_update(u)
end

@project.readers.each do |u|
  ProjelementMailer.notify_update(u)
end

Is there a more DRY Rails approach that lets me express this in a more concise way?

Andrew Marshall · Accepted Answer · 2012-02-28 04:58:01Z

1

Just combine all the arrays:

(@project.admins + @project.members + @project.readers).each do |u|
  ProjelementMailer.notify_update(u)
end

You may also wish to call uniq on the combined array to remove duplicates. For a more literal dynamic approach:

[:admins, :members, :readers].each do |sym|
  @project.send(sym).each do |u|
    ProjelementMailer.notify_update(u)
  end
end

answered Feb 28, 2012 at 4:58

Andrew Marshall

97.3k20 gold badges228 silver badges217 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Daniel May Over a year ago

Thanks Andrew. Also appreciate the code with more literal dynamic approach.

Andrew Marshall Over a year ago

@DanielMay Dynamic languages allow for many, many ways to accomplish the same (or similar) task. There is rarely one best solution, but it is always nice to explore them to find which one makes the most sense for a given application.

Daniel May Over a year ago

Yeah, I didn't grow up so much with dynamic languages and am trying to get acclimatised as much as possible to patterns (and anti-patterns). Thanks for your help on this :)

Naren Sisodiya · Accepted Answer · 2012-02-28 05:14:11Z

1

you can join all arrays using | for all uniq users and call each on it, but make sure all methods admins, members, readers are not returning nil object

(@project.admins | @project.members | @project.readers).each do |u|
  ProjelementMailer.notify_update(u)
end

edited Feb 28, 2012 at 5:14

answered Feb 28, 2012 at 5:01

Naren Sisodiya

7,2882 gold badges27 silver badges35 bronze badges

3 Comments

Andrew Marshall Over a year ago

Nice. Didn't know about | with arrays. Though don't call it bitwise OR, because it's not—it's a method that performs a union.

Andrew Marshall Over a year ago

I know what it is, but you're saying it's something very different by saying "| (bit or)" in your answer.

Daniel May Over a year ago

Thanks Naren, helpful! Discussion also helpful

Collectives™ on Stack Overflow

How to email users in multiple arrays, the Rails way?

2 Answers 2

3 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related