writing conditions for error messages for form_for

Question

I'm writing some if/elsif statements to display error messages. When I leave the username blank and fill the other fields in correctly, it still goes to the else statement and displays "All fields must be completed." Can someone point out the error in my logic/syntax?

<% if @user.errors.any? %>
  <div id="error_explanation" class="round">

     <% if  @user[:name].nil? and @user[:email].not.nil? and @user[:password].not.nil? and @user[:password_digest].not.nil? %>      
        <h2>Please enter a valid username. </h2>


    <% else %>      <!--If any field is left blank -->
        <h2>All fields must be completed. </h2>

    <% end %>
 </div>
<% end %>

Let me know if you need anything else.

AyJay · Accepted Answer · 2012-03-05 08:59:17Z

2

I think railscasts has great episode for validations http://railscasts.com/episodes/211-validations-in-rails-3

Check it out, your current approach is sure to make some troubles in the future where you need to check validations a lot.

answered Mar 5, 2012 at 8:59

AyJay

5487 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Huy Over a year ago

I created my validation tests for my user in user.rb. My code above is simply to display the error messages on the site for visitors. Is there a reason why the video approach is more effective than my current approach?

AyJay Over a year ago

Few reasons I can think top off my head: 1) You only have to write validation once. Meanining you don't have to copy same code over and over and over. 2) Therefore makes code cleaner. 3) All Errors are nicely hashed in @object.errors. 4) Can do things like this railscasts.com/episodes/263-client-side-validations

gt5050 · Accepted Answer · 2012-03-05 07:52:46Z

0

Try this

<% if  @user[:name].nil? and !@user[:email].nil? and !@user[:password].nil? and !@user[:password_digest].nil? %>

answered Mar 5, 2012 at 7:52

gt5050

5817 silver badges13 bronze badges

3 Comments

Huy Over a year ago

I tried that, but it still displays the else message. <% if @user[:name].nil? && !@user[:email].nil? && !@user[:password].nil? && !@user[:password_digest].nil? %>

Huy Over a year ago

Here is the debug information: name: ' ' email: [email protected] password: foobar password_confirmation: foobar

gt5050 Over a year ago

you can log the fields in the conditional statement and check if they are being set as you are thinking

Collectives™ on Stack Overflow

writing conditions for error messages for form_for

2 Answers 2

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related