Javascript for loop not looping

Question

I have some code that I'm working on for my work. We're trying to loop through all the links on our page and automatically add an onclick event. However, the loop doesn't appear to be "looping" at all. Could somebody please help?

var ourdomainname = "ourdomain.com";


function linkallthelinks(domain) {
    var links = document.getElementsByTagName("a");
    for (i = 0; i < links.length; i++) {
        var link = links[i];
        var href = link.getAttribute("href");

        if (href.indexOf(read_today) != -1) {
            link.setAttribute('onclick', 'alert("Okay")');
        }
    }
}
//function call
linkallthelinks(ourdomainname);

link.setAttribute('onclick', 'alert("Okay")'); <<< this is NOT how you attach events. — tereško
– tereško, Commented Mar 5, 2012 at 16:31
Is it entering the function? do you have an error message? Have you checked the length of the list? — talnicolas
– talnicolas, Commented Mar 5, 2012 at 16:31

Sarfraz · Accepted Answer · 2012-03-05 16:54:55Z

2

Missing quotes here:

if(href.indexOf(read_today) != -1)

Should be:

if(href.indexOf('read_today') != -1)

Overall, this is what you should have:

var ourdomainname = "ourdomain.com";

function linkallthelinks(domain) {
    var links = document.getElementsByTagName("a");
    for (var i = 0; i < links.length; i++) {
        var link = links[i];
        var href = link.getAttribute("href");

        if (href.indexOf('read_today') != -1) {
            link.setAttribute('onclick', 'alert("Okay")');
        }
    }
}
//function call
linkallthelinks(ourdomainname);

edited Mar 5, 2012 at 16:54

answered Mar 5, 2012 at 16:31

Sarfraz

384k81 gold badges561 silver badges613 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

gen_Eric Over a year ago

Don't put quotes around the onclick function.

user1106925 Over a year ago

This: link.setAttribute('onclick', function(){ alert("Okay") }); is incorrect. OP was doing it correctly. The 'alert("Okay");' gets automatically wrapped in a function.

user1106925 Over a year ago

@Rocket: It's setting an attribute, not a property, so either way it's getting the .toString() treatment.

ccarnley7 Over a year ago

Oh, my bad on the quotes around "read_today". Thanks for the catch! However, loop still does not appear to be looping because no events are being attached to the links...

user1106925 Over a year ago

@user1250254: Have you tested the .length of the a elements returned? alert(links.length);? Are you running your script before the elements have been loaded into the page?

|

Tom · Accepted Answer · 2012-03-05 16:32:51Z

1

try this:

if(link.href.indexOf("read_today") != -1)

answered Mar 5, 2012 at 16:32

Tom

4,1702 gold badges26 silver badges40 bronze badges

Collectives™ on Stack Overflow

Javascript for loop not looping

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related