Simple Android SQLite Database Inserstion code

Question

found Error in creating simple SQLite databas Android Application

**03-12 12:57:39.635: E/Database(333): Failure 1 
(near "tablefriends": syntax error) on 0x29b2b0 
when preparing 'create tablefriends(_id integer 
primary key autoincrement,name text not null,address text);

when i write this code in my activity class, my application even did not run. but if i removed this code from activity class , my application run but it gives exception when i insert data into the database

protected void onPause() {
    // TODO Auto-generated method stub
    super.onPause();
    FriendsDataSource s=new FriendsDataSource(this);
    s.closedatabase();

}

@Override
protected void onResume() {
    // TODO Auto-generated method stub
    super.onResume();
    FriendsDataSource s=new FriendsDataSource(this);
    s.opendatabase();
}

public static final String FRIENDS_TABLE_CREATE_STMT="create table"+TABLE_NAME+
       "("+COLUMN_ID+" integer primary key autoincrement,"+
       COLUMN_FRIEND_NAME+" text not null,"+COLUMN_ADDRESS+" text);";

I'd like to add that you should rather create an object-scope instance of FriendsDataSource in onResume and close the database of that instance instead of creating two instances, like mFriendsSource = new FriendsDataSource(this); where mFriendsSource is a member of the class. — Thorsten Dittmar
– Thorsten Dittmar, Commented Mar 12, 2012 at 14:25

Joachim Isaksson · Accepted Answer · 2012-03-12 14:06:33Z

2

You've got problems with your spacing as so often happens when concatenating strings;

"create table" + TABLE_NAME // becomes "create tablefriends"

When ending up with strange SQL errors, it's always a good idea to look at/trace the generated string so that it matches what you expect. In this case, your error message right at the top of the question shows the error though.

The correct version should be;

"create table " + TABLE_NAME // becomes "create table friends"

edited Mar 12, 2012 at 14:06

answered Mar 12, 2012 at 14:01

Joachim Isaksson

182k28 gold badges298 silver badges308 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Zaid Iqbal Over a year ago

it still gives me an exception when i press button of "add friend"

Joachim Isaksson Over a year ago

@ZaidIqbal You're not showing any code or the exception for "Add friend" in this question, you may want to start a new question with all info you have on that.

Zaid Iqbal Over a year ago

03-12 16:56:25.652: E/Database(334): Failure 1 (near "tablefriends": syntax error) on 0x29b268 when preparing 'create tablefriends(_id integer primary key autoincrement,name text not null,address text);'.

Zaid Iqbal Over a year ago

i have debug the code and found exception in this line "long id=friendsDB.insert(FriendsMetaData.TABLE_NAME, null, newFriendValues); "

Collectives™ on Stack Overflow

Simple Android SQLite Database Inserstion code

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related