Ensuring a single instance of an application using WINAPI?

Question

Got curious when someone down-voted this code as a solution to running only a single instance of an application without stating why they did so.

 int hWnd = FindWindow(null, "My Application Title");
 if (hWnd > 0) //If found
 {
     Process.GetCurrentProcess().WaitForExit(600);
     try
     {
        SetForegroundWindow(hWnd); //Activate it
        ShowWindow(hWnd, 9);
        Process.GetCurrentProcess().Kill();
     }
     catch (Exception ex)
     {
        //write to log
     }
 }

 //Import the FindWindow API to find our window
 [DllImport("User32.dll")]
 public static extern int FindWindow(String ClassName, String WindowName);
 //Import the SetForeground API to activate it
 [DllImport("User32.dll")]
 public static extern IntPtr SetForegroundWindow(int hWnd);
 //Import the ShowWindow API to show it
 [DllImport("User32.dll")]
 public static extern bool ShowWindow(int hWnd, int nCmdShow);

Could someone be kind as to explain the drawbacks of this method to me? Thanks.

@SLaks: Just to test whether the other instance is shutting down. — Chibueze Opata
– Chibueze Opata, Commented Mar 15, 2012 at 19:17
@SLaks: OH, geez. I see it now... forgot the showwindow and setforegroundwindow return bool, hence the try catch. That's quite funny, though it's been long I wrote it. — Chibueze Opata
– Chibueze Opata, Commented Mar 15, 2012 at 19:22

Steve Wellens · Accepted Answer · 2012-03-15 19:17:21Z

4

Because if the application is starting twice (accidental clicking), there is a small window of time where the test will fail. Both instances could be starting but neither has created a window yet.

answered Mar 15, 2012 at 19:17

Steve Wellens

20.6k2 gold badges31 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Chibueze Opata Over a year ago

hmmm, makes some sense. This could happen in a very slow PC, I agree.

Alexei Levenkov Over a year ago

On any machine, just not yours :). You are explicitly adding race condition that will happen very rarely, so the application will slowly become know as "the one you need to start very carefully, otherwise restart machine and try again". You will not be able to find reason on you own machine it will never happen when you are watching...

Chibueze Opata Over a year ago

lol @AlexeiLevenkov Funny, I've had a similar user tell-story experience before.

Justin Pihony · Accepted Answer · 2012-03-15 19:15:30Z

1

The drawbacks as far as I can see are that it is overly complicated for what should be a simple solution. You do not need to crack into the windows api to force a single instance of an api. I would guess that is why you got downvoted.

If you follow the links in the Uwe's answer, you will see that you can remain in managed code, which should be your default unless there is some reason you MUST dig a little deeper.

answered Mar 15, 2012 at 19:15

Justin Pihony

67.2k20 gold badges154 silver badges185 bronze badges

2 Comments

Chibueze Opata Over a year ago

what exactly is slightly wrong about using WINAPI? I don't see anything wrong with it.

Justin Pihony Over a year ago

I have no problem using the windows API, however there are managed wrappers that you can use. All I am trying to get at is that unmanaged code is more dangerous and requires more care, so why take the risk?

Collectives™ on Stack Overflow

Ensuring a single instance of an application using WINAPI?

2 Answers 2

3 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related