python TypeError: object does not support indexing

Question

Here's the faulty bit of my code:

class Room(object):
    def __init__(self):
        self.hotspots = []
        self.image = []
        self.item = []

    def newhotspot(*args):
        new = {'Name' : None,
               'id' : None,
               'rect' : None,
               'Takeable' : None,
               'Lookable' : None,
               'Speakable' : None,
               'Itemable' : None,
               'Goable' : None}

        for i in args:
            new[i[0]] = i[1]
        new['id'] = len(self.hotspots)
        self.hotspots.append(new)

CityTrader = Room()

CityTrader.newhotspot(('Name', 'Trader'),
                      ('Takeable', 'Yes'))

The goal is to have a dictionary with all the keys set to none but the ones specified. However, when I run it I get:

[...]line 85 in <module>
('Takeable', 'Yes'))
[...]line 44, in newhotspot
new[i[0]] = i[1]
TypeError : 'Room' object does not support indexing

Anyone knows why and how to solve this? It seems to work when it's not wrapped inside a class.

Sven Marnach · Accepted Answer · 2012-03-16 22:01:37Z

6

You forgot the self parameter to newhotspot():

def newhotspot(self, *args):
    ...

Since self will be implicitly passed anyway, it ends up as the first item of args.

answered Mar 16, 2012 at 22:01

Sven Marnach

608k123 gold badges969 silver badges866 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Karl Knechtel · Accepted Answer · 2012-03-16 22:36:51Z

1

Every class method must take self as it's first argument.

Try this:

class Room(object):
    def __init__(self):
        self.hotspots = []
        self.image = []
        self.item = []

    def newhotspot(self, *args):
       new = {'Name' : None,
       'id' : None,
       'rect' : None,
       'Takeable' : None,
       'Lookable' : None,
       'Speakable' : None,
       'Itemable' : None,
       'Goable' : None}

       for i in args:
           new[i[0]] = i[1]
       new['id'] = len(self.hotspots)
       self.hotspots.append(new)

CityTrader = Room()

CityTrader.newhotspot(('Name', 'Trader'),
                      ('Takeable', 'Yes'))

edited Mar 16, 2012 at 22:36

Karl Knechtel

61.5k14 gold badges134 silver badges194 bronze badges

answered Mar 16, 2012 at 22:11

Patrick T Nelson

1,25412 silver badges21 bronze badges

1 Comment

Sven Marnach Over a year ago

Wrong, class methods take the class as first argument. Instance methods have self as the first parameter.

Collectives™ on Stack Overflow

python TypeError: object does not support indexing

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related