Simple php if else loop help needed

Question

I have a function like this

function cp_module_ranks_getRank($uid){
        return cp_module_ranks_pointsToRank(cp_getPoints($uid));
    }

It returns the member rank based on points i set. For example my settings has

250 Points = Bronze
1000 Points = Silver
2500 Points = Gold
10000 Points = Diamond
25000 Points = Platinum

So if a user has 11234 points then that function return value as Diamond

Now i would like to set a variable based on this rank.

$affdays is the variable

I mean like this

If user rank is Bronze $affdays = 30
If user rank is Silver $affdays = 60
If user rank is Gold $affdays = 90
If user rank is Diamond $affdays = 180
If user rank is Platinum $affdays = 360
Default $affdays = 10

Thanks.

why dont you use array ?

safarov
– safarov

2012-03-19 20:41:04 +00:00
Commented Mar 19, 2012 at 20:41 — safarov
– safarov, Commented Mar 19, 2012 at 20:41

jasonlfunk · Accepted Answer · 2012-03-19 21:27:16Z

4

You can use a switch statement:

$user_rank = cp_module_ranks_getRank($id);

switch($user_rank) {
    case 'Bronze':
      $affdays = 30;
      break;
    case 'Silver':
      $affdays = 60;
      break;
    case 'Gold':
      $affdays = 90;
      break;
    case 'Diamond':
      $affdays = 180;
      break;
    case 'Platinum':
      $affdays = 360;
      break;
    default:
      $affdays = 10;
}

edited Mar 19, 2012 at 21:27

answered Mar 19, 2012 at 20:42

jasonlfunk

5,2695 gold badges32 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Giri Over a year ago

Hi thanks.. But my main problem is that i have no idea how to bring that function cp_module_ranks_getRank($uid) inside switch statement. Do i have to assign your $user_rank variable in that function?. If yes how?

jasonlfunk Over a year ago

I'm not sure what you actually want. Do you want the cp_module_ranks_getRank() function to return that $affdays value?

Giri Over a year ago

No.. cp_module_ranks_getRank() returns rank value like Bronze which is correct. But you used a new variable $user_rank. I'm a php noob. Thats why i asked this question. But now your new variable confusing me more.. I mean from where you passing the values?. Your code has no connection with my cp_module_ranks_getRank() function.

Giri Over a year ago

Yep thats what i'm talking about. Thanks. I'll accept your answer. :)

rjz · Accepted Answer · 2012-03-19 21:01:44Z

4

How about just creating an array and looking up the corresponding example?

$rank = 'Bronze';
$rank_days = array(
  'Bronze' => 30,
  'Silver' => 60
  // etc
);

if (array_key_exists($rank, $rank_days)) {
  $affdays = $rank_days[$rank]; // 30
} else {
  $affdays = 10;
}

edited Mar 19, 2012 at 21:01

answered Mar 19, 2012 at 20:42

rjz

16.5k3 gold badges39 silver badges35 bronze badges

3 Comments

Robbie Over a year ago

+1 this is much better than multiple ifs or a switch statement

Giri Over a year ago

Hi can you tell me how to assign that function to a variable? Do i have to use like this? $rank = cp_module_ranks_getRank($uid); and what about the default affdays value?

rjz Over a year ago

That looks ok. I'm just assigning the ranks as the keys of an array and the number of days as the corresponding value; why not test if no corresponding key exists in the array using array_key_exists() and assign a default value if needed?

PaulKoeck · Accepted Answer · 2012-03-19 20:42:43Z

2

Use the switch statement

switch ($user_rank) {
   case "bronze":
      //code
   break;
   case "silver":
      //code
   break;
   default:
      $affdays = 10;
   break;
   //and so on
}

it's like an If statement with multiple "elseif's" and it works much faster

answered Mar 19, 2012 at 20:42

PaulKoeck

1343 bronze badges

Comments

callumacrae · Accepted Answer · 2012-03-19 20:43:46Z

1

The following code should do the trick:

    if (cp_module_ranks_getRank($user) === 'Bronze') {
        $affdays = 30;
    } else if (cp_module_ranks_getRank($user) === 'Silver') {
        $affdays = 60;
    } else if (cp_module_ranks_getRank($user) === 'Gold') {

    ...

    } else {
        $affdays = 10;
    }

EDIT: The switch statement answer is far better than this one

answered Mar 19, 2012 at 20:43

callumacrae

8,45310 gold badges34 silver badges50 bronze badges

Collectives™ on Stack Overflow

Simple php if else loop help needed

4 Answers 4

4 Comments

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related