onclick return and javascript

Question

and thanks to anyone who can help me!

I have a text with this code:

<a onclick="return showPic(this); mostrarespectacular()" href="Imatges/productosnuevos/urbano01.jpg">&nbsp Circuito Espectacular Barcelona</a>

and the scripts are:

<script type="text/javascript">
function showPic (whichpic) {
 if (document.getElementById) {
  document.getElementById('imgContenedor').src = whichpic.href;
  if (whichpic.title) {
      document.getElementById('imgDescripcion').childNodes[0].innerHTML = whichpic.innerHTML;
  }
  return false;
 } else {
  return true;
 }
}
</script>
<script type="text/javascript">
function mostrarespectacular() {
    div = document.getElementById('circuloespectacular');
    div.style.display = 'inline';
}
function cerrarespectacular() {
    div = document.getElementById('circuloespectacular');
    div.style.display='none';
}
</script>

and my problem is that the first function works perfect but not the second one (which has to show a div). Any ideas of what i'm doing wrong? Thanks!!

Adam Bergmark · Accepted Answer · 2012-03-21 21:20:59Z

2

You return from the onclick after the first function call. Remove that and you should be fine.

answered Mar 21, 2012 at 21:20

Adam Bergmark

7,6363 gold badges23 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1249723 Over a year ago

mmmm no, if I delete "return" the image i need to see in a div, opens in the same page! I solved the problem just changing the order of the functions!!!!

fenone · Accepted Answer · 2012-03-21 21:31:36Z

1

The "return" is branching out of the script after calling the showPic() function. Remove the return or place it before the "mostrarespectacular()" call or move it to the end, etc.

answered Mar 21, 2012 at 21:31

fenone

1,1048 silver badges7 bronze badges

1 Comment

fenone Over a year ago

@Adam had the same conclusion. I just didn't see that response until I had posted mine. : ) Glad you got it working anyway!

Collectives™ on Stack Overflow

onclick return and javascript

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related