How do I make a bash script continue part of a loop only if there is no error in the first step of the loop?

Question

I currently have a .command file for Mac that contains the following:

for f in ~/Desktop/Uploads/*.flv
do
     /usr/local/bin/ffmpeg -i "$f" -vcodec copy -acodec libfaac -ab 128k -ar 48000 -async 1 "${f%.*}".mp4
     rmtrash "$f"
done

How can I tell bash to only execute rmtrash if ffmpeg doesn't produce an error?

anubhava · Accepted Answer · 2012-03-30 21:10:15Z

5

Check for return value of ffmpeg command using $? or put && between 2 commands like this:

for f in ~/Desktop/Uploads/*.flv
do
     /usr/local/bin/ffmpeg -i "$f" -vcodec copy -acodec libfaac -ab 128k\
     -ar 48000 -async 1 "${f%.*}".mp4 && rmtrash "$f"
done

As per the bash manual:

command1 && command2
   command2 is executed if, and only if, command1 returns an exit status of zero.

answered Mar 30, 2012 at 21:10

anubhava

790k67 gold badges603 silver badges671 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Eli Greenberg Over a year ago

Thanks for the help. Will this continue the loop if one file fails but there are more to convert?

anubhava Over a year ago

Yes it will continue to loop.

Eli Greenberg Over a year ago

Wonderful! Thanks for the quick response. Off to converting!

Collectives™ on Stack Overflow

How do I make a bash script continue part of a loop only if there is no error in the first step of the loop?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related